You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Amar3tto (via GitHub)" <gi...@apache.org> on 2026/10/20 11:42:07 UTC

[PR] Fix SpannerIO PerformanceTests workflows [beam]

Amar3tto opened a new pull request, #40683:
URL: https://github.com/apache/beam/pull/40683

   Fixes #40660, fixes #40661
   
   Successful runs:
   https://github.com/apache/beam/actions/runs/39405250368
   https://github.com/apache/beam/actions/runs/39405225694
   
   <!--
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    - [ ] Replace these instructions with a description of your change and why you have made it.
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123` or `fixes #456`).
    - [ ] Update `CHANGES.md` with noteworthy changes.
   
   See [CONTRIBUTING.md]() for more details.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix SpannerIO PerformanceTests workflows [beam]

Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto commented on code in PR #40683:
URL: https://github.com/apache/beam/pull/40683#discussion_r4329670771


##########
sdks/python/apache_beam/io/gcp/experimental/spannerio_read_perf_test.py:
##########
@@ -133,7 +134,8 @@ def make_insert_mutations(element):
           | 'Produce rows' >> Read(
               SyntheticSource(self.parse_synthetic_source_options()))
           | 'Format' >> Map(format_record)
-          | 'Make mutations' >> FlatMap(make_insert_mutations)
+          | 'Make mutations' >> FlatMap(
+              make_insert_mutations).with_output_types(_Mutator)

Review Comment:
   I found a possible trigger: #40413, merged on October 8, switched Python load/performance tests from 3.10 to 3.11. This may have exposed the existing FlatMap type inference issue. I haven't confirmed it yet, but I didn't find any changes to the SpannerIO API or type checking itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix SpannerIO PerformanceTests workflows [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40683:
URL: https://github.com/apache/beam/pull/40683#issuecomment-6291794191

   Assigning reviewers:
   
   R: @tvalentyn for label python.
   Backup reviewer: shunping (if the main reviewer is unresponsive, you can escalate to them by tagging their username)
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix SpannerIO PerformanceTests workflows [beam]

Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto merged PR #40683:
URL: https://github.com/apache/beam/pull/40683


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix SpannerIO PerformanceTests workflows [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #40683:
URL: https://github.com/apache/beam/pull/40683#discussion_r4329807641


##########
sdks/python/apache_beam/io/gcp/experimental/spannerio_read_perf_test.py:
##########
@@ -133,7 +134,8 @@ def make_insert_mutations(element):
           | 'Produce rows' >> Read(
               SyntheticSource(self.parse_synthetic_source_options()))
           | 'Format' >> Map(format_record)
-          | 'Make mutations' >> FlatMap(make_insert_mutations)
+          | 'Make mutations' >> FlatMap(
+              make_insert_mutations).with_output_types(_Mutator)

Review Comment:
   Ok - could we try to run before/after that change and see if it shows the issue? If yes, then I am fine with the change. If no, we should really understand why we need this first



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix SpannerIO PerformanceTests workflows [beam]

Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto commented on code in PR #40683:
URL: https://github.com/apache/beam/pull/40683#discussion_r4338609360


##########
sdks/python/apache_beam/io/gcp/experimental/spannerio_read_perf_test.py:
##########
@@ -133,7 +134,8 @@ def make_insert_mutations(element):
           | 'Produce rows' >> Read(
               SyntheticSource(self.parse_synthetic_source_options()))
           | 'Format' >> Map(format_record)
-          | 'Make mutations' >> FlatMap(make_insert_mutations)
+          | 'Make mutations' >> FlatMap(
+              make_insert_mutations).with_output_types(_Mutator)

Review Comment:
   Confirmed - Python 3.10 works https://github.com/apache/beam/actions/runs/39619250068



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix SpannerIO PerformanceTests workflows [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #40683:
URL: https://github.com/apache/beam/pull/40683#discussion_r4325139504


##########
sdks/python/apache_beam/io/gcp/experimental/spannerio_read_perf_test.py:
##########
@@ -133,7 +134,8 @@ def make_insert_mutations(element):
           | 'Produce rows' >> Read(
               SyntheticSource(self.parse_synthetic_source_options()))
           | 'Format' >> Map(format_record)
-          | 'Make mutations' >> FlatMap(make_insert_mutations)
+          | 'Make mutations' >> FlatMap(
+              make_insert_mutations).with_output_types(_Mutator)

Review Comment:
   Do we know what change caused this to start failing? Did we make a breaking change to something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org