You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/12/21 07:47:26 UTC
[GitHub] [bigtop] elukey opened a new pull request #845: BIGTOP-3622 - replace $(PWD) with $(CURDIR) in Debian rule files
elukey opened a new pull request #845:
URL: https://github.com/apache/bigtop/pull/845
The only remaining one is the Oozie's rules file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #845: BIGTOP-3622 - replace $(PWD) with $(CURDIR) in Debian rule files
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #845:
URL: https://github.com/apache/bigtop/pull/845#issuecomment-999332388
@oflebbe thanks for the review! This would be my first commit to merge, and I have to admit that I have never used github/gitbox so I don't know the workflow. I checked https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute but it doesn't seem up to date afaics, what is the best procedure?
- Can we merge from the Github mirror UI? (If so I don't find a way to do it)
- Should we merge from Gitbox's UI?
- Alternatively, merge + push from the gitbox local repo, but I suspect that there is a simpler way.
In this case I'd like to merge this change on the master branch, and if it applies cleanly, also on branch-1.5 (people will need to rebuild oozie for https://issues.apache.org/jira/browse/BIGTOP-3621).
Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] oflebbe commented on pull request #845: BIGTOP-3622: replace $(PWD) with $(CURDIR) in Debian rule files
Posted by GitBox <gi...@apache.org>.
oflebbe commented on pull request #845:
URL: https://github.com/apache/bigtop/pull/845#issuecomment-1000438920
Patch applies not cleanly to branch-1.5 , sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] oflebbe commented on pull request #845: BIGTOP-3622 - replace $(PWD) with $(CURDIR) in Debian rule files
Posted by GitBox <gi...@apache.org>.
oflebbe commented on pull request #845:
URL: https://github.com/apache/bigtop/pull/845#issuecomment-999434587
I see it , and I was looking for some UI at github to enable/disable .
Maybe you are missing the steps mentioned in https://blogs.apache.org/infra/entry/apache-and-github-a-friendly ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] oflebbe commented on pull request #845: BIGTOP-3622 - replace $(PWD) with $(CURDIR) in Debian rule files
Posted by GitBox <gi...@apache.org>.
oflebbe commented on pull request #845:
URL: https://github.com/apache/bigtop/pull/845#issuecomment-999423213
Sorry I was in "At Work Mode" when I did the Github review, I was supposed to use JIRA for Reviews.
However AFAIK the gitbox / github integration should work the same as committing the usual way directly on the ASF infra, but I have to admit I used the "usual way" (as in the How to Contribute) before. If unsure simply ignore my review here and use git as you would normally do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] oflebbe merged pull request #845: BIGTOP-3622: replace $(PWD) with $(CURDIR) in Debian rule files
Posted by GitBox <gi...@apache.org>.
oflebbe merged pull request #845:
URL: https://github.com/apache/bigtop/pull/845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #845: BIGTOP-3622: replace $(PWD) with $(CURDIR) in Debian rule files
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #845:
URL: https://github.com/apache/bigtop/pull/845#issuecomment-1000453963
Thanks a lot @oflebbe! I updated https://github.com/apache/bigtop/pull/846 to include this bit, it should be good (so when the other one will be merged we'll include the CURDIR fix as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #845: BIGTOP-3622 - replace $(PWD) with $(CURDIR) in Debian rule files
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #845:
URL: https://github.com/apache/bigtop/pull/845#issuecomment-999432214
@oflebbe exactly I don't see it, so I was wondering if I had to use gitbox etc..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] oflebbe commented on pull request #845: BIGTOP-3622 - replace $(PWD) with $(CURDIR) in Debian rule files
Posted by GitBox <gi...@apache.org>.
oflebbe commented on pull request #845:
URL: https://github.com/apache/bigtop/pull/845#issuecomment-999425987
Ah did I get the question wrong -- as in you don't see the "Rebase and merge" button on the PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #845: BIGTOP-3622: replace $(PWD) with $(CURDIR) in Debian rule files
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #845:
URL: https://github.com/apache/bigtop/pull/845#issuecomment-1000402892
@oflebbe I am currently trying to sort out my account, if you have time would you mind to merge the change on master and (if possible) also on branch-1.5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org