[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26760: [SPARK-30129][core] Set client's id in TransportClient after successful auth.

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #26760: [SPARK-30129][core] Set client's id in TransportClient after successful auth.
URL: https://github.com/apache/spark/pull/26760#discussion_r353980308
 
 

 ##########
 File path: common/network-common/src/main/java/org/apache/spark/network/crypto/AuthClientBootstrap.java
 ##########
 @@ -97,6 +97,8 @@ public void doBootstrap(TransportClient client, Channel channel) {
       }
       doSaslAuth(client, channel);
     }
+
+    client.setClientId(appId);
 
 Review comment:
   This seems to cause `IllegalStateException: Client ID has already been set` in `AuthIntegrationSuite`.
   ```
     public void setClientId(String id) {
       Preconditions.checkState(clientId == null, "Client ID has already been set.");
       this.clientId = id;
     }
   ```
   Do we need to check with `getClientId`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org