You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2020/05/19 16:23:43 UTC

[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #384: Validate PadCharacter with pattern facet

jadams-tresys commented on a change in pull request #384:
URL: https://github.com/apache/incubator-daffodil/pull/384#discussion_r427433086



##########
File path: daffodil-core/src/test/resources/test/example-of-most-dfdl-constructs.dfdl.xml
##########
@@ -249,7 +249,8 @@
     <annotation>
       <appinfo source="http://www.ogf.org/dfdl/">
         <dfdl:element nilKind="literalValue" />
-       <!--  Gives a not yet implemented, so commented out.
+       <!--  Gives a SDE: newVariableInstance may only be used on
+            group reference, sequence or choice, so needs review (5/18/20).

Review comment:
       That is correct. The DFDL Spec specifies that newVariableInstance may only be used on group reference, sequence, or choice. The correct place for the newVariableInstance call would probably be within the "gr" group declaration on line 175




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org