You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2007/09/20 23:59:50 UTC
[jira] Created: (OFBIZ-1258) Improved FreeMarkerWorker
Improved FreeMarkerWorker
-------------------------
Key: OFBIZ-1258
URL: https://issues.apache.org/jira/browse/OFBIZ-1258
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Priority: Minor
Minor fixups for the recent changes to the file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1258) Improved FreeMarkerWorker
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530473 ]
Adrian Crum commented on OFBIZ-1258:
------------------------------------
David,
Thank you for taking the time to work on this. The code changes resulted from me trying to get the code back to its original working state.
I understand what you're saying about a proliferation of methods, but at the same time this is a "Worker" class that would be expected to accomodate more than one scenario. Before the recent changes, calling classes had several template rendering options: render a template with only a template location, render a template with a String object that contains the template, and render a template with an existing template reader.
In rev 573442 you changed the code to address the template reader object not being closed issue. At the same time it appeared you tried to eliminate "a bunch of methods that aren't really needed" - which broke peripheral code. Those methods were needed. Al attempted to fix the broken code in rev 576766.
My approach to this situation was to go back to rev 564957 and apply only your changes that fixed the reader not being closed issue. I didn't eliminate any existing methods. That's why it appears I made unnecessary changes.
As long as the problem is fixed, I don't care. My preference is to avoid redundant code, but as long as it works, that's all that matters.
> Improved FreeMarkerWorker
> -------------------------
>
> Key: OFBIZ-1258
> URL: https://issues.apache.org/jira/browse/OFBIZ-1258
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: FreeMarkerWorker.patch, FreeMarkerWorker.patch
>
>
> Minor fixups for the recent changes to the file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1258) Improved FreeMarkerWorker
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1258:
-------------------------------
Attachment: FreeMarkerWorker.patch
Improved patch. All readers are closed - even the ones created outside the class.
> Improved FreeMarkerWorker
> -------------------------
>
> Key: OFBIZ-1258
> URL: https://issues.apache.org/jira/browse/OFBIZ-1258
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: FreeMarkerWorker.patch, FreeMarkerWorker.patch
>
>
> Minor fixups for the recent changes to the file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1258) Improved FreeMarkerWorker
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530411 ]
David E. Jones commented on OFBIZ-1258:
---------------------------------------
Adrian I reviewed your comments and the patch and I'm not sure if I like, or understood the point of, all of the changes.
In SVN rev 579571 I did fix up the sync block for the cache get/put in the renderTemplateFromString method, which I think was the main thing you were trying to fix.
Please let me know what else needs to be fixed or cleaned up. One thing I didn't want to do is add a bunch of methods that aren't really needed (there is a HUGE proliferation of this sort of method in OFBiz and in spite of the intent I think this makes that APIs more difficult to use instead of easier).
> Improved FreeMarkerWorker
> -------------------------
>
> Key: OFBIZ-1258
> URL: https://issues.apache.org/jira/browse/OFBIZ-1258
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: FreeMarkerWorker.patch, FreeMarkerWorker.patch
>
>
> Minor fixups for the recent changes to the file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1258) Improved FreeMarkerWorker
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David E. Jones closed OFBIZ-1258.
---------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: David E. Jones
See last comments.
> Improved FreeMarkerWorker
> -------------------------
>
> Key: OFBIZ-1258
> URL: https://issues.apache.org/jira/browse/OFBIZ-1258
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: FreeMarkerWorker.patch, FreeMarkerWorker.patch
>
>
> Minor fixups for the recent changes to the file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1258) Improved FreeMarkerWorker
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1258:
-------------------------------
Attachment: FreeMarkerWorker.patch
Attached patch fixes the changes from rev 576766. The new method didn't properly synchronize the cache.
Also made a few code cleanups.
> Improved FreeMarkerWorker
> -------------------------
>
> Key: OFBIZ-1258
> URL: https://issues.apache.org/jira/browse/OFBIZ-1258
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: FreeMarkerWorker.patch
>
>
> Minor fixups for the recent changes to the file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1258) Improved FreeMarkerWorker
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531099 ]
David E. Jones commented on OFBIZ-1258:
---------------------------------------
I'll go ahead and close this then.
If there are specific issues or other bugs they can be filed separately.
> Improved FreeMarkerWorker
> -------------------------
>
> Key: OFBIZ-1258
> URL: https://issues.apache.org/jira/browse/OFBIZ-1258
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: FreeMarkerWorker.patch, FreeMarkerWorker.patch
>
>
> Minor fixups for the recent changes to the file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.