You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/12/23 23:24:53 UTC
[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #273: Convert README to markdown
ok2c commented on a change in pull request #273:
URL: https://github.com/apache/httpcomponents-client/pull/273#discussion_r548317438
##########
File path: README.md
##########
@@ -3,30 +3,44 @@ Apache HttpComponents Client
Welcome to the HttpClient component of the Apache HttpComponents project.
+[](https://travis-ci.com/apache/httpcomponents-client)
+[](https://maven-badges.herokuapp.com/maven-central/org.apache.httpcomponents.client5/httpclient5)
+[](https://opensource.org/licenses/Apache-2.0)
+
Building Instructions
---------------------
-For building from source instructions please refer to BUILDING.txt.
+For building from source instructions please refer to [BUILDING.txt](./BUILDING.txt).
Dependencies
------------
HttpClient main module requires Java 7 compatible runtime and
depends on the following external libraries:
-* Apache HttpComponents HttpCore
-* Apache Logging Log4j2 API
-* Apache Commons Codec
+* [Apache HttpComponents HttpCore](https://github.com/apache/httpcomponents-core)
+* [Apache Logging Log4j2 API](https://github.com/apache/logging-log4j2)
Review comment:
@michael-o It is not old but wrong. The correct dependencies are
* Apache HttpComponents HttpCore
* SLF4J
* Apache Commons Codec
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org