You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/08/01 10:10:30 UTC
[GitHub] [cloudstack] digitalgust commented on issue #3531: Create VM error
in iso network/KVM
digitalgust commented on issue #3531: Create VM error in iso network/KVM
URL: https://github.com/apache/cloudstack/issues/3531#issuecomment-517220326
update bug summary:
Issue : MgmtUI call api to create physical network when Zone creation, the two api have same parameter , but forgot vnetRange parameter when create physical network 2 ,
mgmt log:
```
2019-08-01 17:36:50,729 DEBUG [c.c.a.ApiServlet] (qtp532087022-19:ctx-6362ba4e) (logid:85dbf67a) ===START=== 10.0.1.11 -- GET command=createPhysicalNetwork&zoneid=7a2a1e5b-d0cc-4580-9891-ae9a3cb0095e&name=Physical%20Network%201&isolationmethods=VLAN&response=json&_=1564652210626
2019-08-01 17:36:50,756 DEBUG [c.c.a.ApiServlet] (qtp532087022-21:ctx-50abb42c) (logid:1a5a22a7) ===START=== 10.0.1.11 -- GET command=createPhysicalNetwork&zoneid=7a2a1e5b-d0cc-4580-9891-ae9a3cb0095e&name=Physical%20Network%202&isolationmethods=VLAN&response=json&_=1564652210627
```
so java source method call parameter vnetRange is null,
```
public PhysicalNetwork com.cloud.network.NetworkServiceImpl. createPhysicalNetwork(final Long zoneId, final String vnetRange, final String networkSpeed, final List<String> isolationMethods,
String broadcastDomainRangeStr, final Long domainId, final List<String> tags, final String name){
...
if (vnetRange != null) { // ;;------------------------ vnetRange is null
addOrRemoveVnets(vnetRange.split(","), pNetwork);
}
...
}
```
/ui/scripts/zoneWizard.js
bug here , forgot vlanRangeStart and vlanRangeEnd para:
```
} else if (args.data.zone.networkType == "Advanced") {
$(args.data.physicalNetworks).each(function(index) {
var thisPhysicalNetwork = this;
var array1 = [];
array1.push("&name=" + todb(thisPhysicalNetwork.name));
if (thisPhysicalNetwork.isolationMethod != null && thisPhysicalNetwork.isolationMethod.length > 0)
array1.push("&isolationmethods=" + todb(thisPhysicalNetwork.isolationMethod));
$.ajax({
url: createURL("createPhysicalNetwork&zoneid=" + args.data.returnedZone.id + array1.join("")),
```
Please fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services