You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/14 08:38:24 UTC

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #18924: [fix][txn] fix error in recoverTracker.handleCommittingAndAbortingTransaction()

congbobo184 commented on code in PR #18924:
URL: https://github.com/apache/pulsar/pull/18924#discussion_r1048158033


##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java:
##########
@@ -129,7 +130,6 @@ public void replayComplete() {
                     } else {

Review Comment:
   better to move this line, because 
   https://github.com/apache/pulsar/pull/18924/files#diff-70bdccda00334bdcc596cb6fea9f166021fc858af8c0432a3ee86a6911150d07R123
   in some case the tc will not recover success



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org