[jira] [Commented] (FLINK-4212) Lock PID file when starting daemons

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378248#comment-15378248 ] 

ASF GitHub Bot commented on FLINK-4212:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/2251

    [FLINK-4212] [scripts] Lock PID file when starting daemons

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 4212_lock_pid_file_when_starting_daemons

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2251.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2251
    
----
commit e7d59835ab011e38de61a0b304cd93f1ca7cefb7
Author: Greg Hogan <co...@greghogan.com>
Date:   2016-07-14T15:55:41Z

    [FLINK-4212] [scripts] Lock PID file when starting daemons

----


> Lock PID file when starting daemons
> -----------------------------------
>
>                 Key: FLINK-4212
>                 URL: https://issues.apache.org/jira/browse/FLINK-4212
>             Project: Flink
>          Issue Type: Improvement
>          Components: Startup Shell Scripts
>    Affects Versions: 1.1.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>
> As noted on the mailing list (0), when multiple TaskManagers are started in parallel (using pdsh) there is a race condition on updating the pid: 1) the pid file is first read to parse the process' index, 2) the process is started, and 3) on success the daemon pid is appended to the pid file.
> We could use a tool such as {{flock}} to lock on the pid file while starting the Flink daemon.
> 0: http://mail-archives.apache.org/mod_mbox/flink-user/201607.mbox/%3CCA%2BssbKXw954Bz_sBRwP6db0FntWyGWzTyP7wJZ5nhOeQnof3kg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)