You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by do...@hyperreal.org on 1999/08/04 05:43:03 UTC
cvs commit: modperl/t/net/perl taint.pl test
dougm 99/08/03 20:43:02
Modified: . Changes ToDo
src/modules/perl mod_perl.h
t/net/perl taint.pl test
Log:
fix $ENV{PATH} corruption
Revision Changes Path
1.334 +2 -0 modperl/Changes
Index: Changes
===================================================================
RCS file: /home/cvs/modperl/Changes,v
retrieving revision 1.333
retrieving revision 1.334
diff -u -r1.333 -r1.334
--- Changes 1999/08/04 02:33:13 1.333
+++ Changes 1999/08/04 03:42:52 1.334
@@ -8,6 +8,8 @@
=item 1.21_01-dev
+fix $ENV{PATH} corruption
+
mod_perl_version.h removed from MANIFEST
fix modules/sandwich test
1.196 +0 -2 modperl/ToDo
Index: ToDo
===================================================================
RCS file: /home/cvs/modperl/ToDo,v
retrieving revision 1.195
retrieving revision 1.196
diff -u -r1.195 -r1.196
--- ToDo 1999/08/04 02:33:14 1.195
+++ ToDo 1999/08/04 03:42:55 1.196
@@ -11,8 +11,6 @@
- sfio patch [Lupe Christoph <lu...@lupe-christoph.de>]
-- SetEnv PATH cause garbled value (is it mod_env or mod_perl?)
-
- libapreq: Apache::Cookie format sync w/ CGI.pm
- document Apache::File
1.85 +3 -2 modperl/src/modules/perl/mod_perl.h
Index: mod_perl.h
===================================================================
RCS file: /home/cvs/modperl/src/modules/perl/mod_perl.h,v
retrieving revision 1.84
retrieving revision 1.85
diff -u -r1.84 -r1.85
--- mod_perl.h 1999/08/03 22:56:09 1.84
+++ mod_perl.h 1999/08/04 03:42:59 1.85
@@ -286,9 +286,10 @@
#define mp_setenv(key, val) \
{ \
int klen = strlen(key); \
- hv_store(GvHV(envgv), key, klen, newSVpv(val,0), FALSE); \
+ SV *sv = newSVpv(val,0); \
+ hv_store(GvHV(envgv), key, klen, sv, FALSE); \
HV_SvTAINTED_on(GvHV(envgv), key, klen); \
- my_setenv(key, val); \
+ my_setenv(key, SvPVX(sv)); \
}
#define mp_SetEnv(key, val) \
1.3 +1 -1 modperl/t/net/perl/taint.pl
Index: taint.pl
===================================================================
RCS file: /home/cvs/modperl/t/net/perl/taint.pl,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- taint.pl 1998/01/09 17:35:10 1.2
+++ taint.pl 1999/08/04 03:43:00 1.3
@@ -4,7 +4,7 @@
use strict;
my $r = Apache->request;
-$ENV{PATH} = "/bin";
+local $ENV{PATH} = "/bin";
$r->content_type("text/plain");
$r->send_http_header;
1.15 +1 -1 modperl/t/net/perl/test
Index: test
===================================================================
RCS file: /home/cvs/modperl/t/net/perl/test,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- test 1998/12/22 16:01:43 1.14
+++ test 1999/08/04 03:43:01 1.15
@@ -29,7 +29,7 @@
$Scalar = 1;
my $r = Apache->request;
-$ENV{PATH} = "/bin";
+local $ENV{PATH} = "/bin";
use vars qw($is_xs);
$is_xs = ($r->uri =~ /_xs/);