You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Rohan Desai <de...@gmail.com> on 2019/02/03 00:27:47 UTC
[DISCUSS] KIP-425: Add some Log4J Kafka Appender Properties for
Producing to Secured Brokers
https://cwiki.apache.org/confluence/display/KAFKA/KIP-425%3A+Add+some+Log4J+Kafka+Appender+Properties+for+Producing+to+Secured+Brokers
Re: [DISCUSS] KIP-425: Add some Log4J Kafka Appender Properties for
Producing to Secured Brokers
Posted by Dongjin Lee <do...@apache.org>.
@Rohan
I reviewed both of the security feature and your KIP today, and now
understanding what you are meaning! In short, you are trying to reach
parity of the supported authentication mechanism[^1], configuration
method[^2] between client and Log4J appender. Isn't it?
Then, It would be much better to expand the motivation section with more
detail and context, like this:
```
Currently, Kafka client supports various authentication mechanisms with
following configuration methods:
1. Using the client configuration property `sasl.jaas.config`
2. Using the static JAAS config file
However, the existing Log4J Kafka appender only supports producing to
brokers that use the GSSAPI SASL (aka Kerberos) mechanism, using static
JAAS config file configurations.
This KIP covers extending the current implementation to support the PLAIN
SASL mechanism with property-based configuration method, reaching parity
between client and log appender.
```
@Gwen
Thanks for your kind response! Could you give us a +1 to the voting
thread[^3]? You know, we need committer's binding +1. (I already voted with
+1.)
Best,
Dongjin
[^1]: GSSAPI (Kerberos), PLAIN, etc.
[^2]: property-based, file-based.
[^3]:
https://lists.apache.org/thread.html/4c8c26de0a14950daa65025c6bce819fa6527efe816e49d2bd3ea40f@%3Cdev.kafka.apache.org%3E
On Tue, Feb 5, 2019 at 2:25 AM Gwen Shapira <gw...@confluent.io> wrote:
> I've worked with the module a bit, a while ago. Overall, the proposal
> is simple and reasonable - just bring the Log4J appender up to the
> same configuration we already have elsewhere. So, I support this KIP.
> Thanks, Rohan :)
>
> On Mon, Feb 4, 2019 at 1:54 AM Dongjin Lee <do...@apache.org> wrote:
> >
> > Hi Rohan,
> >
> > Thank you for your proposal. Since the release of 2.2.0 is imminent, most
> > committers are on working frenzy now so don't be distressed if there are
> > few responses for the discussion thread.
> >
> > Although I am not a committer, here are some notes I would like to share
> > about submitting a KIP:
> >
> > 1. After searching the mailing list archive, I found that you did not ask
> > whether this feature is needed or there is another way to achieve the
> goal
> > you want. (If not, forgive me.) It is always good to make some prior
> > discussion about some feature before submitting a KIP. [example
> > <
> https://lists.apache.org/thread.html/6cc42d8f994bb1f37a5cad3278369a1800f614ad3d0789ed7a9cab7f@%3Cdev.spark.apache.org%3E
> >
> > ]
> >
> > 2. After opening a discussion thread like this
> > <
> https://lists.apache.org/thread.html/967980193088e2c8cbb39a4782e358961fee828c6c50d880610a8353@%3Cdev.kafka.apache.org%3E
> >,
> > please update the KIP with the permalink to the email message. You can
> find
> > it in here <ht...@kafka.apache.org>.
> >
> > 3. It seems like it is much better to provide some detailed reasons or
> > scenarios where the proposed changes are needed or useful in the
> Motivation
> > section.
> >
> > Here are some examples:
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-110%3A+Add+Codec+for+ZStandard+Compression
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Allow+fine-grained+configuration+for+compression
> >
> > So, I made some minor revisions to your Proposal.
> >
> > @Committers:
> >
> > Is there anyone who worked on the log module or security feature?
> >
> > Best,
> > Dongjin
> >
> >
> > On Sun, Feb 3, 2019 at 2:24 PM Rohan Desai <de...@gmail.com>
> wrote:
> >
> > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-425%3A+Add+some+Log4J+Kafka+Appender+Properties+for+Producing+to+Secured+Brokers
> > >
> >
> >
> > --
> > *Dongjin Lee*
> >
> > *A hitchhiker in the mathematical world.*
> > *github: <http://goog_969573159/>github.com/dongjinleekr
> > <https://github.com/dongjinleekr>linkedin:
> kr.linkedin.com/in/dongjinleekr
> > <https://kr.linkedin.com/in/dongjinleekr>speakerdeck:
> speakerdeck.com/dongjin
> > <https://speakerdeck.com/dongjin>*
>
>
>
> --
> Gwen Shapira
> Product Manager | Confluent
> 650.450.2760 | @gwenshap
> Follow us: Twitter | blog
>
--
*Dongjin Lee*
*A hitchhiker in the mathematical world.*
*github: <http://goog_969573159/>github.com/dongjinleekr
<https://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
<https://kr.linkedin.com/in/dongjinleekr>speakerdeck: speakerdeck.com/dongjin
<https://speakerdeck.com/dongjin>*
Re: [DISCUSS] KIP-425: Add some Log4J Kafka Appender Properties for
Producing to Secured Brokers
Posted by Gwen Shapira <gw...@confluent.io>.
I've worked with the module a bit, a while ago. Overall, the proposal
is simple and reasonable - just bring the Log4J appender up to the
same configuration we already have elsewhere. So, I support this KIP.
Thanks, Rohan :)
On Mon, Feb 4, 2019 at 1:54 AM Dongjin Lee <do...@apache.org> wrote:
>
> Hi Rohan,
>
> Thank you for your proposal. Since the release of 2.2.0 is imminent, most
> committers are on working frenzy now so don't be distressed if there are
> few responses for the discussion thread.
>
> Although I am not a committer, here are some notes I would like to share
> about submitting a KIP:
>
> 1. After searching the mailing list archive, I found that you did not ask
> whether this feature is needed or there is another way to achieve the goal
> you want. (If not, forgive me.) It is always good to make some prior
> discussion about some feature before submitting a KIP. [example
> <https://lists.apache.org/thread.html/6cc42d8f994bb1f37a5cad3278369a1800f614ad3d0789ed7a9cab7f@%3Cdev.spark.apache.org%3E>
> ]
>
> 2. After opening a discussion thread like this
> <https://lists.apache.org/thread.html/967980193088e2c8cbb39a4782e358961fee828c6c50d880610a8353@%3Cdev.kafka.apache.org%3E>,
> please update the KIP with the permalink to the email message. You can find
> it in here <ht...@kafka.apache.org>.
>
> 3. It seems like it is much better to provide some detailed reasons or
> scenarios where the proposed changes are needed or useful in the Motivation
> section.
>
> Here are some examples:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-110%3A+Add+Codec+for+ZStandard+Compression
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Allow+fine-grained+configuration+for+compression
>
> So, I made some minor revisions to your Proposal.
>
> @Committers:
>
> Is there anyone who worked on the log module or security feature?
>
> Best,
> Dongjin
>
>
> On Sun, Feb 3, 2019 at 2:24 PM Rohan Desai <de...@gmail.com> wrote:
>
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-425%3A+Add+some+Log4J+Kafka+Appender+Properties+for+Producing+to+Secured+Brokers
> >
>
>
> --
> *Dongjin Lee*
>
> *A hitchhiker in the mathematical world.*
> *github: <http://goog_969573159/>github.com/dongjinleekr
> <https://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
> <https://kr.linkedin.com/in/dongjinleekr>speakerdeck: speakerdeck.com/dongjin
> <https://speakerdeck.com/dongjin>*
--
Gwen Shapira
Product Manager | Confluent
650.450.2760 | @gwenshap
Follow us: Twitter | blog
Re: [DISCUSS] KIP-425: Add some Log4J Kafka Appender Properties for
Producing to Secured Brokers
Posted by Dongjin Lee <do...@apache.org>.
Hi Rohan,
Thank you for your proposal. Since the release of 2.2.0 is imminent, most
committers are on working frenzy now so don't be distressed if there are
few responses for the discussion thread.
Although I am not a committer, here are some notes I would like to share
about submitting a KIP:
1. After searching the mailing list archive, I found that you did not ask
whether this feature is needed or there is another way to achieve the goal
you want. (If not, forgive me.) It is always good to make some prior
discussion about some feature before submitting a KIP. [example
<https://lists.apache.org/thread.html/6cc42d8f994bb1f37a5cad3278369a1800f614ad3d0789ed7a9cab7f@%3Cdev.spark.apache.org%3E>
]
2. After opening a discussion thread like this
<https://lists.apache.org/thread.html/967980193088e2c8cbb39a4782e358961fee828c6c50d880610a8353@%3Cdev.kafka.apache.org%3E>,
please update the KIP with the permalink to the email message. You can find
it in here <ht...@kafka.apache.org>.
3. It seems like it is much better to provide some detailed reasons or
scenarios where the proposed changes are needed or useful in the Motivation
section.
Here are some examples:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-110%3A+Add+Codec+for+ZStandard+Compression
https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Allow+fine-grained+configuration+for+compression
So, I made some minor revisions to your Proposal.
@Committers:
Is there anyone who worked on the log module or security feature?
Best,
Dongjin
On Sun, Feb 3, 2019 at 2:24 PM Rohan Desai <de...@gmail.com> wrote:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-425%3A+Add+some+Log4J+Kafka+Appender+Properties+for+Producing+to+Secured+Brokers
>
--
*Dongjin Lee*
*A hitchhiker in the mathematical world.*
*github: <http://goog_969573159/>github.com/dongjinleekr
<https://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
<https://kr.linkedin.com/in/dongjinleekr>speakerdeck: speakerdeck.com/dongjin
<https://speakerdeck.com/dongjin>*