You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/05 14:38:38 UTC
[GitHub] [superset] michael-s-molina opened a new issue #12965: Can't select for bulk delete in chart/dashboard list when using card view
michael-s-molina opened a new issue #12965:
URL: https://github.com/apache/superset/issues/12965
### Expected results
When using card view and bulk selecting, a click on the card should not navigate to detail page. The cards shouldn't flick left when bulk select is clicked.
### Actual results
When using card view and bulk selecting, a click on the card navigate to detail page and I can't make further selections. Also when I click in bulk selecting, the cards panel receive a right margin making the cards flick left.
#### Screenshots
#### How to reproduce the bug
1. Go to dashboard list
2. Click on card view
3. Click on bulk select
4. Try to select more than one card
5. You can't because the first selection triggers a navigation
### Environment
- superset version: `master`
- python version: `2.7.16`
- node.js version: `15.5.1`
### Checklist
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #12965: [Delete]Can't select for bulk delete in chart/dashboard list when using card view
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #12965:
URL: https://github.com/apache/superset/issues/12965#issuecomment-777848454
This was working previously. I think we made some changes to make the entire card clickable at some point which likely broke this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Steejay commented on issue #12965: [Delete]Can't select for bulk delete in chart/dashboard list when using card view
Posted by GitBox <gi...@apache.org>.
Steejay commented on issue #12965:
URL: https://github.com/apache/superset/issues/12965#issuecomment-777806435
Agreed. This is a bug and not the desired interaction. Original spec for bulk selecting one or multiple cards:
cc @mihir174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12965: Can't select for bulk delete in chart/dashboard list when using card view
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12965:
URL: https://github.com/apache/superset/issues/12965#issuecomment-774192467
committing to this change. however, we wanna promote list view over card at this point due to the performance issues. may not get to it soon. marking `good first issue` if anyone from the community wanna work on it. thanks @michael-s-molina !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #12965: [Delete]Can't select for bulk delete in chart/dashboard list when using card view
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12965:
URL: https://github.com/apache/superset/issues/12965#issuecomment-774192467
committing to this change. however, we wanna promote list view over card at this point due to the performance issues. may not get to it soon. marking `good first issue` if anyone from the community wanna work on it. Also need design input.
thanks @michael-s-molina !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lilykuang closed issue #12965: [Delete]Can't select for bulk delete in chart/dashboard list when using card view
Posted by GitBox <gi...@apache.org>.
lilykuang closed issue #12965:
URL: https://github.com/apache/superset/issues/12965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org