You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/03/16 11:22:35 UTC
[GitHub] [incubator-dolphinscheduler] mrproliu opened a new pull request #5067: Fix shell task ${setValue(key,value)} is not working
mrproliu opened a new pull request #5067:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5067
## Purpose of the pull request
Fix the shell task `${setValue(key,value)}` is not working.
## Brief change log
Setting var pool content to the task.
## Verify this pull request
This pull request is code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #5067: Fix shell task ${setValue(key,value)} is not working
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #5067:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5067#issuecomment-800245742
> > > Is anyone could help me to re-run the e2e? It's looks like downloading maven plugin failed.
> >
> >
> > I will re-run this e2e
>
> thanks
hi, I can't find the corresponding issue, if there is no issue, please create an issue first , thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #5067: Fix shell task ${setValue(key,value)} is not working
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #5067:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5067#issuecomment-800262595
hi, deeply thanks for your contribution, can you create an issue for this pr, when created, I will merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #5067: Fix shell task ${setValue(key,value)} is not working
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #5067:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5067#issuecomment-800240568
> Is anyone could help me to re-run the e2e? It's looks like downloading maven plugin failed.
I will re-run this e2e
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] mrproliu commented on pull request #5067: Fix shell task ${setValue(key,value)} is not working
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #5067:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5067#issuecomment-800202528
Is anyone could help me to re-run the e2e? It's looks like downloading maven plugin failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] mrproliu commented on pull request #5067: Fix shell task ${setValue(key,value)} is not working
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #5067:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5067#issuecomment-800242354
> > Is anyone could help me to re-run the e2e? It's looks like downloading maven plugin failed.
>
> I will re-run this e2e
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs merged pull request #5067: [BUG][Worker]Fix shell task ${setValue(key,value)} is not working
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #5067:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5067
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #5067: Fix shell task ${setValue(key,value)} is not working
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #5067:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5067#issuecomment-800190143
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5067&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5067&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5067&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5067&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5067&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #5067: Fix shell task ${setValue(key,value)} is not working
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #5067:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5067#issuecomment-800277440
considering that it's your first contribution, I think we can get deep communiction, you can contact me through mail or add wechat(Kris_Evil), when mail or added, please tell me who you are, I think I can help to familiar with the DolphinScheduler if you meet with problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] mrproliu commented on pull request #5067: Fix shell task ${setValue(key,value)} is not working
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #5067:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5067#issuecomment-800275965
> hi, deeply thanks for your contribution, can you create an issue for this pr, when created, I will merge it.
Thanks for your response. I have created https://github.com/apache/incubator-dolphinscheduler/issues/5071, please take a look. Sorry, I'm not sure about the PR process, so I just created the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org