[GitHub] [cxf] kwin commented on a diff in pull request #954: CXF-8712 One-off issue with retries

[GitBox <gi...@apache.org>]

kwin commented on code in PR #954:
URL: https://github.com/apache/cxf/pull/954#discussion_r893073176


##########
rt/features/clustering/src/main/java/org/apache/cxf/clustering/RetryStrategy.java:
##########
@@ -42,7 +42,11 @@ public List<Endpoint> getAlternateEndpoints(Exchange exchange) {
     }
 
     protected <T> T getNextAlternate(List<T> alternates) {
-        return stillTheSameAddress() ? alternates.get(0) : alternates.remove(0);
+        // is the amount of retries for the first alternate already exceeded?
+        if (!stillTheSameAddress()) {
+            alternates.remove(0);
+        }
+        return alternates.isEmpty() ? null : alternates.get(0);

Review Comment:
   Any other idea how to fix without returning null? Or do we need to change the contract for of selectNextAlternate to allow null return values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org