You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/03/02 19:37:41 UTC

[Impala-ASF-CR] IMPALA-9445: skip test local tz conversion for hbase 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15338


Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase
......................................................................

IMPALA-9445: skip test_local_tz_conversion for hbase

This skips the test for filesystems where we don't start
HBase. It's a bit unfortunate that we have to disable
all of this test, so this is a stopgap to get builds
green.

Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
---
M tests/custom_cluster/test_local_tz_conversion.py
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/15338/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9445: skip test local tz conversion for hbase

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15338 )

Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 21:23:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9445: skip test local tz conversion for hbase

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15338 )

Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5390/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 20:11:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9445: skip test local tz conversion for hbase

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15338 )

Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5391/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 21:59:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9445: skip test local tz conversion for hbase

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15338 )

Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase
......................................................................


Patch Set 2:

Tested manually, skipping CI to unblock builds faster.


-- 
To view, visit http://gerrit.cloudera.org:8080/15338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 21:31:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9445: skip test local tz conversion for hbase

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15338 )

Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15338/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15338/2//COMMIT_MSG@10
PS2, Line 10: bit unfortunate
I think that it doesn't add extra coverage to run this on S3, so it's ok to leave it this way. I added this test only to avoid the very specific bug of depending on flag use_local_tz_for_unix_timestamp_conversions when reading timestamps from different fileformats, as this bug could not be detected by tests that run with default flags.



-- 
To view, visit http://gerrit.cloudera.org:8080/15338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 21:31:32 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9445: skip test local tz conversion for hbase

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15338 )

Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15338/1/tests/custom_cluster/test_local_tz_conversion.py
File tests/custom_cluster/test_local_tz_conversion.py:

http://gerrit.cloudera.org:8080/#/c/15338/1/tests/custom_cluster/test_local_tz_conversion.py@22
PS1, Line 22: from tests.common.skip import SkipIfBuildType, SkipIfABFS, SkipIfADLS, SkipIfS3
flake8: F401 'tests.common.skip.SkipIfBuildType' imported but unused



-- 
To view, visit http://gerrit.cloudera.org:8080/15338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 19:38:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9445: skip test local tz conversion for hbase

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15338 )

Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Mar 2020 21:31:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9445: skip test local tz conversion for hbase

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15338

to look at the new patch set (#2).

Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase
......................................................................

IMPALA-9445: skip test_local_tz_conversion for hbase

This skips the test for filesystems where we don't start
HBase. It's a bit unfortunate that we have to disable
all of this test, so this is a stopgap to get builds
green.

Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
---
M tests/custom_cluster/test_local_tz_conversion.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/15338/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9445: skip test local tz conversion for hbase

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15338 )

Change subject: IMPALA-9445: skip test_local_tz_conversion for hbase
......................................................................

IMPALA-9445: skip test_local_tz_conversion for hbase

This skips the test for filesystems where we don't start
HBase. It's a bit unfortunate that we have to disable
all of this test, so this is a stopgap to get builds
green.

Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Reviewed-on: http://gerrit.cloudera.org:8080/15338
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M tests/custom_cluster/test_local_tz_conversion.py
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Csaba Ringhofer: Looks good to me, approved
  Tim Armstrong: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fb603ebe0a5820d2eed0b6ec5dca2980fd5521d
Gerrit-Change-Number: 15338
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>