You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/27 09:49:26 UTC
[GitHub] [incubator-apisix] sshniro opened a new pull request #1349: Fix for
not printing the error logs if max_retry_count is 0
sshniro opened a new pull request #1349: Fix for not printing the error logs if max_retry_count is 0
URL: https://github.com/apache/incubator-apisix/pull/1349
### Summary
If the batch processor max_retry_count is set to 0, then it will not print the error log when it fails to send the data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming merged pull request #1349: Batch
Processor: Fix for rescheduling execution for max_retry_count is 0 and 1
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1349: Batch Processor: Fix for rescheduling execution for max_retry_count is 0 and 1
URL: https://github.com/apache/incubator-apisix/pull/1349
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1349: Batch Processor: Fix for rescheduling execution for max_retry_count
is 0 and 1
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1349: Batch Processor: Fix for rescheduling execution for max_retry_count is 0 and 1
URL: https://github.com/apache/incubator-apisix/pull/1349#discussion_r399269247
##########
File path: t/utils/batch-processor.t
##########
@@ -316,7 +316,6 @@ GET /t
done
--- no_error_log
BatchProcessor[log buffer] activating flush due to no activity
Review comment:
`BatchProcessor ` -> `Batch Processor`?
We need to update the source code too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1349: Batch Processor: Fix for rescheduling execution for max_retry_count
is 0 and 1
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1349: Batch Processor: Fix for rescheduling execution for max_retry_count is 0 and 1
URL: https://github.com/apache/incubator-apisix/pull/1349#discussion_r399272859
##########
File path: lua/apisix/utils/batch-processor.lua
##########
@@ -57,12 +57,12 @@ function execute_func(premature, batch_processor, batch)
return
end
- local ok, err = batch_processor.func(batch.entries)
+ local ok, err = batch_processor.func(batch.entries, batch_processor.batch_max_size)
if not ok then
+ core.log.error(fmt("Batch Processor[%s] failed to process entries: ",
Review comment:
optimize: we should avoid to generate any new object , it will increase the load on the Lua GC and make APISIX performance worse.
good style: `core.log.error("Batch Processor[", batch_processor.name, "] failed to process entries: ", err)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services