You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/19 04:02:31 UTC
[GitHub] [arrow] hcoona opened a new pull request #7493: ARROW-9183: [C++] Fix build with clang & old libstdc++.
hcoona opened a new pull request #7493:
URL: https://github.com/apache/arrow/pull/7493
See https://issues.apache.org/jira/browse/ARROW-9183# for further details & discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7493: ARROW-9183: [C++] Fix build with clang & old libstdc++.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7493:
URL: https://github.com/apache/arrow/pull/7493#issuecomment-646422867
https://issues.apache.org/jira/browse/ARROW-9183
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on a change in pull request #7493: ARROW-9183: [C++] Fix build with clang & old libstdc++.
Posted by GitBox <gi...@apache.org>.
bkietz commented on a change in pull request #7493:
URL: https://github.com/apache/arrow/pull/7493#discussion_r442924149
##########
File path: cpp/src/arrow/util/atomic_shared_ptr.h
##########
@@ -24,7 +24,9 @@
namespace arrow {
namespace internal {
-#if !defined(__clang__) && defined(__GNUC__) && __GNUC__ < 5
+// https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html#abi.versioning
+// https://gcc.gnu.org/develop.html#timeline
+#if defined(__GLIBCXX__) && __GLIBCXX__ < 20150422
// atomic shared_ptr operations only appeared in gcc 5,
// emulate them with unsafe ops on gcc 4.x.
Review comment:
```suggestion
#if defined(__GLIBCXX__) && __GLIBCXX__ < 20150422
// Atomic shared_ptr operations only appeared in gcc 5's libstdc++,
// emulate them with unsafe ops if unavailable.
//
// The libstdc++ version is a the encoded release date of gcc 5, see
// https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html#abi.versioning.__GLIBCXX__
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on pull request #7493: ARROW-9183: [C++] Fix build with clang & old libstdc++.
Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #7493:
URL: https://github.com/apache/arrow/pull/7493#issuecomment-648252136
Hmm, there's a failure building with GCC 4.8 https://github.com/apache/arrow/pull/7493/checks?check_run_id=791725319#step:9:534
The `#ifdef` condition seems to be failing to detect too-old libstdc++
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hcoona commented on pull request #7493: ARROW-9183: [C++] Fix build with clang & old libstdc++.
Posted by GitBox <gi...@apache.org>.
hcoona commented on pull request #7493:
URL: https://github.com/apache/arrow/pull/7493#issuecomment-648542491
Got it. It seems that the gcc 4.8.5 is released later than gcc 4.9.2 & gcc 5.1. I'll take a future investigation on how to detect the missing of `std::atomic_load` overloads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz closed pull request #7493: ARROW-9183: [C++] Fix build with clang & old libstdc++.
Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #7493:
URL: https://github.com/apache/arrow/pull/7493
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org