[GitHub] [spark] HeartSaVioR edited a comment on pull request #31826: [SPARK-34731][CORE] Avoid ConcurrentModificationException when redacting properties in EventLoggingListener

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on pull request #31826:
URL: https://github.com/apache/spark/pull/31826#issuecomment-799005292


   Similar issue was reported from SPARK-32027 - probably the same occurrence or not.
   
   As I commented in SPARK-32027, I think the fundamental problem is that mutability on event object (including all fields in event object of course), which would be problematic via 1) co-use of event object between listener"s" 2) co-use of specific objects between even object and main logic. But I also couldn't evaluate the "cost" (in terms of necessary work & performance hurt) of fixing fundamental problem altogether, so fixing one by one once we figure out would make sense.
   
   Thanks for submitting a PR! I'll take a look today.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org