You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "Ryan Skraba (Jira)" <ji...@apache.org> on 2022/09/14 18:39:00 UTC

[jira] [Resolved] (AVRO-3618) [Java] TestBinaryDecoder should check consistency with directBinaryDecoder

     [ https://issues.apache.org/jira/browse/AVRO-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Skraba resolved AVRO-3618.
-------------------------------
    Fix Version/s: 1.11.2
       Resolution: Fixed

Cherry-picked to [branch-1.11|https://github.com/apache/avro/commit/92b155d2ffca5bcc971ce508b1f0dfc50b1daa79].

> [Java] TestBinaryDecoder should check consistency with directBinaryDecoder
> --------------------------------------------------------------------------
>
>                 Key: AVRO-3618
>                 URL: https://issues.apache.org/jira/browse/AVRO-3618
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Ryan Skraba
>            Assignee: Christophe Le Saec
>            Priority: Major
>              Labels: pull-request-available, starter
>             Fix For: 1.12.0, 1.11.2
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The unit tests for TestBinaryDecoder were originally parameterized so that _every_ test verifies that {{*BinaryDecoder*}} and {{*DirectBinaryDecoder*}} show the same behaviour.
> In the meantime, some tests have been added or modified that only test BinaryDecoder (twice).  Where possible, this should be fixed so that both classes are checked and that their behaviour are the same.
> Notably: the {{testNegativeBytesLength}} throws a different exception when DirectBinaryEncoder is used.
> Please pay special attention around the tests deserializing invalid binary data: this might be an unrecoverable error for Avro that throws a runtime exception but shouldn't consume unnecessary resources or cause OutOfMemoryErrors.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)