You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/06/04 15:30:38 UTC

[GitHub] [couchdb] noahshaw11 opened a new pull request #3604: Build enc at top level

noahshaw11 opened a new pull request #3604:
URL: https://github.com/apache/couchdb/pull/3604


   ## Overview
   
   Currently, the `enc` (https://github.com/davisp/erlang-native-compiler) binary is kept in the `couchdb-jiffy` repository. This is a security risk. This PR builds the `enc` binary at the top level so we can verify where it came from and have it available for dependencies.
   
   ## Testing recommendations
   
   Follow the steps to build CouchDB. After `./configure` is run, an `enc` binary should be located in `/bin`. Following the rest of the steps should lead to a successful build.
   
   ## Related Issues or Pull Requests
   
   Remove `enc` from `couchdb-jiffy` and build it at top-level CouchDB instead: https://github.com/apache/couchdb-jiffy/pull/5
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] noahshaw11 commented on pull request #3604: Build enc at top level

Posted by GitBox <gi...@apache.org>.
noahshaw11 commented on pull request #3604:
URL: https://github.com/apache/couchdb/pull/3604#issuecomment-888532402


   Closing this again. Upstream is not responding on merging the required PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] iilyak commented on pull request #3604: Build enc at top level

Posted by GitBox <gi...@apache.org>.
iilyak commented on pull request #3604:
URL: https://github.com/apache/couchdb/pull/3604#issuecomment-872947096


   > dependencies like jiffy hard code the path to their enc binary like here. 
   
   I've opened a PR with the upstream https://github.com/davisp/jiffy/pull/212


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] noahshaw11 commented on pull request #3604: Build enc at top level

Posted by GitBox <gi...@apache.org>.
noahshaw11 commented on pull request #3604:
URL: https://github.com/apache/couchdb/pull/3604#issuecomment-872464784


   While this PR does correctly build `enc` and place it in `bin/`, the `enc` binary will never be used. This is because dependencies like [jiffy](https://github.com/davisp/jiffy) hard code the path to their `enc` binary like [here](https://github.com/davisp/jiffy/blob/master/rebar.config#L39-L40). While it can be argued that `enc` can just be added to the `$PATH`, this adds an extra dependency that is not necessarily needed. I am closing this for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] noahshaw11 commented on pull request #3604: Build enc at top level

Posted by GitBox <gi...@apache.org>.
noahshaw11 commented on pull request #3604:
URL: https://github.com/apache/couchdb/pull/3604#issuecomment-873069415


   Reopening PR since @iilyak has created an upstream PR for Jiffy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] noahshaw11 closed pull request #3604: Build enc at top level

Posted by GitBox <gi...@apache.org>.
noahshaw11 closed pull request #3604:
URL: https://github.com/apache/couchdb/pull/3604


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] noahshaw11 closed pull request #3604: Build enc at top level

Posted by GitBox <gi...@apache.org>.
noahshaw11 closed pull request #3604:
URL: https://github.com/apache/couchdb/pull/3604


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org