You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by marekchen <gi...@git.apache.org> on 2018/03/12 07:02:12 UTC
[GitHub] incubator-weex pull request #1065: Update AbstractEditComponent.java
GitHub user marekchen opened a pull request:
https://github.com/apache/incubator-weex/pull/1065
Update AbstractEditComponent.java
**if** *isBugFix* **:**
* [ ] Make sure that you add at least one unit test for the bug which you had fixed.
**elif** *isNewFeature* **:**
* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [ ] Update test scripts for the feature.
* [ ] Add unit tests for the feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marekchen/incubator-weex master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1065.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1065
----
commit 01b7db464534a094b08c87107cb06bdfd10bc0b0
Author: marekchen <c4...@...>
Date: 2018-03-12T07:01:37Z
Update AbstractEditComponent.java
----
---
[GitHub] incubator-weex pull request #1065: Update AbstractEditComponent.java
Posted by marekchen <gi...@git.apache.org>.
GitHub user marekchen reopened a pull request:
https://github.com/apache/incubator-weex/pull/1065
Update AbstractEditComponent.java
**if** *isBugFix* **:**
* [x] Make sure that you add at least one unit test for the bug which you had fixed.
**elif** *isNewFeature* **:**
* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [ ] Update test scripts for the feature.
* [ ] Add unit tests for the feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marekchen/incubator-weex master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1065.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1065
----
commit 01b7db464534a094b08c87107cb06bdfd10bc0b0
Author: marekchen <c4...@...>
Date: 2018-03-12T07:01:37Z
Update AbstractEditComponent.java
----
---
[GitHub] incubator-weex pull request #1065: Update AbstractEditComponent.java
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/1065
---
[GitHub] incubator-weex pull request #1065: Update AbstractEditComponent.java
Posted by marekchen <gi...@git.apache.org>.
Github user marekchen closed the pull request at:
https://github.com/apache/incubator-weex/pull/1065
---
[GitHub] incubator-weex issue #1065: Update AbstractEditComponent.java
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1065
<!--
0 failure:
1 warning: No Changelog chan...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---