[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1349: nimble/ll: Add support for custom scheduling items

[GitBox <gi...@apache.org>]

sjanc commented on code in PR #1349:
URL: https://github.com/apache/mynewt-nimble/pull/1349#discussion_r968046512


##########
nimble/controller/include/controller/ble_ll_sched.h:
##########
@@ -90,7 +97,12 @@ typedef void (*sched_remove_cb_func)(struct ble_ll_sched_item *sch);
  */
 struct ble_ll_sched_item
 {
+#if MYNEWT_VAL(BLE_LL_EXT_SCHED)
+    uint8_t         sched_type : 4;
+    uint8_t         sched_ext_type : 4;

Review Comment:
   I'd just add ext_type as new byte  (there is hole in struct anyway), when we start adding ISO we may get too close to 15 :)
   
   and regardless of that I'd make external type max value (either 15 or 255)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org