You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by rocco <gi...@git.apache.org> on 2014/03/23 00:06:09 UTC
[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...
GitHub user rocco opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/31
event name and example param update
Some example code failed due to missing arguments, so I added them, also there is no "load" event, must be "loadstop"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rocco/cordova-plugin-inappbrowser docupdate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 364615569c156bd273f432ba30f762a9196f5b4a
Author: Rocco Georgi <ro...@pavingways.com>
Date: 2014-03-22T23:04:24Z
event name and example param update
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...
Posted by rocco <gi...@git.apache.org>.
Github user rocco commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/31#issuecomment-38510907
sorry, overlooked that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/31#issuecomment-38511972
no. github should auto-close this soon, I already merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...
Posted by rocco <gi...@git.apache.org>.
Github user rocco commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/31#issuecomment-38511085
want me to open another pr on dev?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-inappbrowser pull request: event name and example p...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/31#issuecomment-38510496
Pulling this in to dev branch - but take note it should be a pull request to the dev branch always for next time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---