You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by radai <ra...@gmail.com> on 2016/10/03 19:28:36 UTC
backporting a fix to avro 1.7
Hi,
I've recently encountered a bug in avro code generation, for which I
submitted a fix (
https://github.com/apache/avro/commit/be33922c03bd229b885fb9d664b55ce308f6ffaf
).
The issue was discovered while trying to migrate a sizable codebase from
avro 1.4 to 1.7
Would it be possible to back-port this fix to 1.7? bumping 1.7 to latest
would be a lot easier than trying to upgrade 1.4 and now 1.7 code to 1.9
(which is where this will will end up in, when its released?)
I can just open a PR porting the fix to the 1.7 branch (maybe 1.8 branch as
well, for consistency), if thats the procedure.
Thanks in advance,
Radai.
Re: backporting a fix to avro 1.7
Posted by radai <ra...@gmail.com>.
we (linkedin) are doing this as part of a migration path from 1.4 (where a
lot of our code currently is) to 1.7.
migrating everything to 1.8 is not an option right now, and while
eventually we will end up with our own internal fork of 1.7, i was at least
hoping to base it on a new release.
On Mon, Oct 31, 2016 at 9:15 AM, Ryan Blue <rb...@netflix.com.invalid>
wrote:
> I don't think there is much interest in another 1.7 release. Will 1.8.x not
> work for you?
>
> On Thu, Oct 27, 2016 at 9:01 AM, radai <ra...@gmail.com> wrote:
>
> > Hi,
> >
> > Is there an upcoming 1.7 fix release that can pick this up?
> >
> > I'm asking so I could know if I can wait for a 1.7 fix release or move my
> > company's codebase to a forked 1.7
> >
> > On Tue, Oct 4, 2016 at 4:02 PM, radai <ra...@gmail.com>
> wrote:
> >
> > > Thanks,
> > >
> > > I've opened a PR to backport to 1.8 (https://github.com/apache/
> > > avro/pull/140 - has everything that landed originally except additions
> to
> > > CHANGES.txt)
> > >
> > > For 1.7, I had to 1st bring the branch to compile (PR here -
> > > https://github.com/apache/avro/pull/139) and will backport in a
> > > subsequent PR.
> > >
> > >
> > > On Tue, Oct 4, 2016 at 6:28 AM, Sean Busbey <bu...@cloudera.com>
> wrote:
> > >
> > >> (For others, the jira under discussion is AVRO-1901
> > >> https://issues.apache.org/jira/browse/AVRO-1901)
> > >>
> > >> On Tue, Oct 4, 2016 at 8:28 AM, Sean Busbey <bu...@cloudera.com>
> > wrote:
> > >> > yes, it looks like the jira landed in 1.9, though there isn't a fix
> > >> > version set. I don't see anything in the patch that would prevent a
> > >> > backport to 1.7.
> > >> >
> > >> > On Mon, Oct 3, 2016 at 2:28 PM, radai <ra...@gmail.com>
> > >> wrote:
> > >> >> Hi,
> > >> >>
> > >> >> I've recently encountered a bug in avro code generation, for which
> I
> > >> >> submitted a fix (
> > >> >> https://github.com/apache/avro/commit/be33922c03bd229b885fb9
> > >> d664b55ce308f6ffaf
> > >> >> ).
> > >> >>
> > >> >> The issue was discovered while trying to migrate a sizable codebase
> > >> from
> > >> >> avro 1.4 to 1.7
> > >> >>
> > >> >> Would it be possible to back-port this fix to 1.7? bumping 1.7 to
> > >> latest
> > >> >> would be a lot easier than trying to upgrade 1.4 and now 1.7 code
> to
> > >> 1.9
> > >> >> (which is where this will will end up in, when its released?)
> > >> >>
> > >> >> I can just open a PR porting the fix to the 1.7 branch (maybe 1.8
> > >> branch as
> > >> >> well, for consistency), if thats the procedure.
> > >> >>
> > >> >> Thanks in advance,
> > >> >>
> > >> >>
> > >> >> Radai.
> > >> >
> > >> >
> > >> >
> > >> > --
> > >> > busbey
> > >>
> > >>
> > >>
> > >> --
> > >> busbey
> > >>
> > >
> > >
> >
>
>
>
> --
> Ryan Blue
> Software Engineer
> Netflix
>
Re: backporting a fix to avro 1.7
Posted by Ryan Blue <rb...@netflix.com.INVALID>.
I don't think there is much interest in another 1.7 release. Will 1.8.x not
work for you?
On Thu, Oct 27, 2016 at 9:01 AM, radai <ra...@gmail.com> wrote:
> Hi,
>
> Is there an upcoming 1.7 fix release that can pick this up?
>
> I'm asking so I could know if I can wait for a 1.7 fix release or move my
> company's codebase to a forked 1.7
>
> On Tue, Oct 4, 2016 at 4:02 PM, radai <ra...@gmail.com> wrote:
>
> > Thanks,
> >
> > I've opened a PR to backport to 1.8 (https://github.com/apache/
> > avro/pull/140 - has everything that landed originally except additions to
> > CHANGES.txt)
> >
> > For 1.7, I had to 1st bring the branch to compile (PR here -
> > https://github.com/apache/avro/pull/139) and will backport in a
> > subsequent PR.
> >
> >
> > On Tue, Oct 4, 2016 at 6:28 AM, Sean Busbey <bu...@cloudera.com> wrote:
> >
> >> (For others, the jira under discussion is AVRO-1901
> >> https://issues.apache.org/jira/browse/AVRO-1901)
> >>
> >> On Tue, Oct 4, 2016 at 8:28 AM, Sean Busbey <bu...@cloudera.com>
> wrote:
> >> > yes, it looks like the jira landed in 1.9, though there isn't a fix
> >> > version set. I don't see anything in the patch that would prevent a
> >> > backport to 1.7.
> >> >
> >> > On Mon, Oct 3, 2016 at 2:28 PM, radai <ra...@gmail.com>
> >> wrote:
> >> >> Hi,
> >> >>
> >> >> I've recently encountered a bug in avro code generation, for which I
> >> >> submitted a fix (
> >> >> https://github.com/apache/avro/commit/be33922c03bd229b885fb9
> >> d664b55ce308f6ffaf
> >> >> ).
> >> >>
> >> >> The issue was discovered while trying to migrate a sizable codebase
> >> from
> >> >> avro 1.4 to 1.7
> >> >>
> >> >> Would it be possible to back-port this fix to 1.7? bumping 1.7 to
> >> latest
> >> >> would be a lot easier than trying to upgrade 1.4 and now 1.7 code to
> >> 1.9
> >> >> (which is where this will will end up in, when its released?)
> >> >>
> >> >> I can just open a PR porting the fix to the 1.7 branch (maybe 1.8
> >> branch as
> >> >> well, for consistency), if thats the procedure.
> >> >>
> >> >> Thanks in advance,
> >> >>
> >> >>
> >> >> Radai.
> >> >
> >> >
> >> >
> >> > --
> >> > busbey
> >>
> >>
> >>
> >> --
> >> busbey
> >>
> >
> >
>
--
Ryan Blue
Software Engineer
Netflix
Re: backporting a fix to avro 1.7
Posted by radai <ra...@gmail.com>.
Hi,
Is there an upcoming 1.7 fix release that can pick this up?
I'm asking so I could know if I can wait for a 1.7 fix release or move my
company's codebase to a forked 1.7
On Tue, Oct 4, 2016 at 4:02 PM, radai <ra...@gmail.com> wrote:
> Thanks,
>
> I've opened a PR to backport to 1.8 (https://github.com/apache/
> avro/pull/140 - has everything that landed originally except additions to
> CHANGES.txt)
>
> For 1.7, I had to 1st bring the branch to compile (PR here -
> https://github.com/apache/avro/pull/139) and will backport in a
> subsequent PR.
>
>
> On Tue, Oct 4, 2016 at 6:28 AM, Sean Busbey <bu...@cloudera.com> wrote:
>
>> (For others, the jira under discussion is AVRO-1901
>> https://issues.apache.org/jira/browse/AVRO-1901)
>>
>> On Tue, Oct 4, 2016 at 8:28 AM, Sean Busbey <bu...@cloudera.com> wrote:
>> > yes, it looks like the jira landed in 1.9, though there isn't a fix
>> > version set. I don't see anything in the patch that would prevent a
>> > backport to 1.7.
>> >
>> > On Mon, Oct 3, 2016 at 2:28 PM, radai <ra...@gmail.com>
>> wrote:
>> >> Hi,
>> >>
>> >> I've recently encountered a bug in avro code generation, for which I
>> >> submitted a fix (
>> >> https://github.com/apache/avro/commit/be33922c03bd229b885fb9
>> d664b55ce308f6ffaf
>> >> ).
>> >>
>> >> The issue was discovered while trying to migrate a sizable codebase
>> from
>> >> avro 1.4 to 1.7
>> >>
>> >> Would it be possible to back-port this fix to 1.7? bumping 1.7 to
>> latest
>> >> would be a lot easier than trying to upgrade 1.4 and now 1.7 code to
>> 1.9
>> >> (which is where this will will end up in, when its released?)
>> >>
>> >> I can just open a PR porting the fix to the 1.7 branch (maybe 1.8
>> branch as
>> >> well, for consistency), if thats the procedure.
>> >>
>> >> Thanks in advance,
>> >>
>> >>
>> >> Radai.
>> >
>> >
>> >
>> > --
>> > busbey
>>
>>
>>
>> --
>> busbey
>>
>
>
Re: backporting a fix to avro 1.7
Posted by radai <ra...@gmail.com>.
Thanks,
I've opened a PR to backport to 1.8 (https://github.com/apache/avro/pull/140
- has everything that landed originally except additions to CHANGES.txt)
For 1.7, I had to 1st bring the branch to compile (PR here -
https://github.com/apache/avro/pull/139) and will backport in a subsequent
PR.
On Tue, Oct 4, 2016 at 6:28 AM, Sean Busbey <bu...@cloudera.com> wrote:
> (For others, the jira under discussion is AVRO-1901
> https://issues.apache.org/jira/browse/AVRO-1901)
>
> On Tue, Oct 4, 2016 at 8:28 AM, Sean Busbey <bu...@cloudera.com> wrote:
> > yes, it looks like the jira landed in 1.9, though there isn't a fix
> > version set. I don't see anything in the patch that would prevent a
> > backport to 1.7.
> >
> > On Mon, Oct 3, 2016 at 2:28 PM, radai <ra...@gmail.com>
> wrote:
> >> Hi,
> >>
> >> I've recently encountered a bug in avro code generation, for which I
> >> submitted a fix (
> >> https://github.com/apache/avro/commit/be33922c03bd229b885fb9d664b55c
> e308f6ffaf
> >> ).
> >>
> >> The issue was discovered while trying to migrate a sizable codebase from
> >> avro 1.4 to 1.7
> >>
> >> Would it be possible to back-port this fix to 1.7? bumping 1.7 to latest
> >> would be a lot easier than trying to upgrade 1.4 and now 1.7 code to 1.9
> >> (which is where this will will end up in, when its released?)
> >>
> >> I can just open a PR porting the fix to the 1.7 branch (maybe 1.8
> branch as
> >> well, for consistency), if thats the procedure.
> >>
> >> Thanks in advance,
> >>
> >>
> >> Radai.
> >
> >
> >
> > --
> > busbey
>
>
>
> --
> busbey
>
Re: backporting a fix to avro 1.7
Posted by Sean Busbey <bu...@cloudera.com>.
(For others, the jira under discussion is AVRO-1901
https://issues.apache.org/jira/browse/AVRO-1901)
On Tue, Oct 4, 2016 at 8:28 AM, Sean Busbey <bu...@cloudera.com> wrote:
> yes, it looks like the jira landed in 1.9, though there isn't a fix
> version set. I don't see anything in the patch that would prevent a
> backport to 1.7.
>
> On Mon, Oct 3, 2016 at 2:28 PM, radai <ra...@gmail.com> wrote:
>> Hi,
>>
>> I've recently encountered a bug in avro code generation, for which I
>> submitted a fix (
>> https://github.com/apache/avro/commit/be33922c03bd229b885fb9d664b55ce308f6ffaf
>> ).
>>
>> The issue was discovered while trying to migrate a sizable codebase from
>> avro 1.4 to 1.7
>>
>> Would it be possible to back-port this fix to 1.7? bumping 1.7 to latest
>> would be a lot easier than trying to upgrade 1.4 and now 1.7 code to 1.9
>> (which is where this will will end up in, when its released?)
>>
>> I can just open a PR porting the fix to the 1.7 branch (maybe 1.8 branch as
>> well, for consistency), if thats the procedure.
>>
>> Thanks in advance,
>>
>>
>> Radai.
>
>
>
> --
> busbey
--
busbey
Re: backporting a fix to avro 1.7
Posted by Sean Busbey <bu...@cloudera.com>.
yes, it looks like the jira landed in 1.9, though there isn't a fix
version set. I don't see anything in the patch that would prevent a
backport to 1.7.
On Mon, Oct 3, 2016 at 2:28 PM, radai <ra...@gmail.com> wrote:
> Hi,
>
> I've recently encountered a bug in avro code generation, for which I
> submitted a fix (
> https://github.com/apache/avro/commit/be33922c03bd229b885fb9d664b55ce308f6ffaf
> ).
>
> The issue was discovered while trying to migrate a sizable codebase from
> avro 1.4 to 1.7
>
> Would it be possible to back-port this fix to 1.7? bumping 1.7 to latest
> would be a lot easier than trying to upgrade 1.4 and now 1.7 code to 1.9
> (which is where this will will end up in, when its released?)
>
> I can just open a PR porting the fix to the 1.7 branch (maybe 1.8 branch as
> well, for consistency), if thats the procedure.
>
> Thanks in advance,
>
>
> Radai.
--
busbey