You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/03/02 15:53:51 UTC
[GitHub] [airflow] eladkal opened a new pull request, #29878: Prepare docs for 03/2023 wave of Providers
eladkal opened a new pull request, #29878:
URL: https://github.com/apache/airflow/pull/29878
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1124417954
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,35 @@
Changelog
---------
+7.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``add num rows affected to Redshift Data API hook (#29797)``
+* ``Add 'wait_for_completion' param in 'RedshiftCreateClusterOperator' (#29657)``
+* ``Add Amazon Redshift-data to S3<>RS Transfer Operators (#27947)``
+* ``Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters (#29580)``
+* ``Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity (#29623)``
+* ``Implement custom boto waiters for some EMR operators (#29822)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``fix code checking job names in sagemaker (#29245)``
+* ``Avoid emitting fallback message for S3TaskHandler if streaming logs (#29708)``
+* ``Fix Amazon ECS Enums (#29871)``
+
+Misc
+~~~~
+
+* ``Impovements for RedshiftDataOperator: better error reporting and an ability to return SQL results (#29434)``
+* ``Use waiters in ECS Operators instead of inner sensors (#29761)``
Review Comment:
awesome! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1124394857
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,35 @@
Changelog
---------
+7.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``add num rows affected to Redshift Data API hook (#29797)``
+* ``Add 'wait_for_completion' param in 'RedshiftCreateClusterOperator' (#29657)``
+* ``Add Amazon Redshift-data to S3<>RS Transfer Operators (#27947)``
+* ``Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters (#29580)``
+* ``Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity (#29623)``
+* ``Implement custom boto waiters for some EMR operators (#29822)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``fix code checking job names in sagemaker (#29245)``
+* ``Avoid emitting fallback message for S3TaskHandler if streaming logs (#29708)``
+* ``Fix Amazon ECS Enums (#29871)``
+
+Misc
+~~~~
+
+* ``Impovements for RedshiftDataOperator: better error reporting and an ability to return SQL results (#29434)``
+* ``Use waiters in ECS Operators instead of inner sensors (#29761)``
Review Comment:
see https://github.com/apache/airflow/pull/29878/commits/759962e06a4fef20c8754cd9a6b1508b1cc5edd6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1123583646
##########
airflow/providers/mysql/CHANGELOG.rst:
##########
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
Changelog
---------
+4.0.2
+.....
+
+Misc
+~~~~
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend (#29519)``
Review Comment:
Yep, for sure. I was just thinking an easy interim solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #29878:
URL: https://github.com/apache/airflow/pull/29878#issuecomment-1453416032
@Taragolis I regenerated for Amazon provider. Please review the change log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1124408556
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,35 @@
Changelog
---------
+7.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``add num rows affected to Redshift Data API hook (#29797)``
+* ``Add 'wait_for_completion' param in 'RedshiftCreateClusterOperator' (#29657)``
+* ``Add Amazon Redshift-data to S3<>RS Transfer Operators (#27947)``
+* ``Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters (#29580)``
+* ``Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity (#29623)``
+* ``Implement custom boto waiters for some EMR operators (#29822)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``fix code checking job names in sagemaker (#29245)``
+* ``Avoid emitting fallback message for S3TaskHandler if streaming logs (#29708)``
+* ``Fix Amazon ECS Enums (#29871)``
+
+Misc
+~~~~
+
+* ``Impovements for RedshiftDataOperator: better error reporting and an ability to return SQL results (#29434)``
+* ``Use waiters in ECS Operators instead of inner sensors (#29761)``
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1123572510
##########
airflow/providers/mysql/CHANGELOG.rst:
##########
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
Changelog
---------
+4.0.2
+.....
+
+Misc
+~~~~
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend (#29519)``
Review Comment:
We know we want to move to newsfragment... just no one had the time to make it happen yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #29878:
URL: https://github.com/apache/airflow/pull/29878#issuecomment-1453399658
@eladkal Just wondering could we include https://github.com/apache/airflow/pull/29871 which fix #29761 or exclude #29761 from this release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1124389131
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,35 @@
Changelog
---------
+7.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``add num rows affected to Redshift Data API hook (#29797)``
+* ``Add 'wait_for_completion' param in 'RedshiftCreateClusterOperator' (#29657)``
+* ``Add Amazon Redshift-data to S3<>RS Transfer Operators (#27947)``
+* ``Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters (#29580)``
+* ``Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity (#29623)``
+* ``Implement custom boto waiters for some EMR operators (#29822)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``fix code checking job names in sagemaker (#29245)``
+* ``Avoid emitting fallback message for S3TaskHandler if streaming logs (#29708)``
+* ``Fix Amazon ECS Enums (#29871)``
+
+Misc
+~~~~
+
+* ``Impovements for RedshiftDataOperator: better error reporting and an ability to return SQL results (#29434)``
+* ``Use waiters in ECS Operators instead of inner sensors (#29761)``
Review Comment:
I guess we can't do anything when fix introduced for feature/changes in the same release cycle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1124403303
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,35 @@
Changelog
---------
+7.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``add num rows affected to Redshift Data API hook (#29797)``
+* ``Add 'wait_for_completion' param in 'RedshiftCreateClusterOperator' (#29657)``
+* ``Add Amazon Redshift-data to S3<>RS Transfer Operators (#27947)``
+* ``Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters (#29580)``
+* ``Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity (#29623)``
+* ``Implement custom boto waiters for some EMR operators (#29822)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``fix code checking job names in sagemaker (#29245)``
+* ``Avoid emitting fallback message for S3TaskHandler if streaming logs (#29708)``
+* ``Fix Amazon ECS Enums (#29871)``
+
+Misc
+~~~~
+
+* ``Impovements for RedshiftDataOperator: better error reporting and an ability to return SQL results (#29434)``
+* ``Use waiters in ECS Operators instead of inner sensors (#29761)``
Review Comment:
It shout be another way round: #29761 introduce actual changes, and some kind of bug fixes and I guess better put it in Bug Fixes, and #29871 could be hided because it fix some errors which introduced during #29761 and found by https://aws-mwaa.github.io/open-source/system-tests/dashboard.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1123452723
##########
airflow/providers/mysql/CHANGELOG.rst:
##########
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
Changelog
---------
+4.0.2
+.....
+
+Misc
+~~~~
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend (#29519)``
Review Comment:
We can not
The proccess of release look for exact match between commit title and changelog. this is also why we can not manually fix typos :(
What we can do if you feel we need better description here is to add more free text above this line (like we do for breaking changes). Do you have something in mind?
##########
airflow/providers/mysql/CHANGELOG.rst:
##########
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
Changelog
---------
+4.0.2
+.....
+
+Misc
+~~~~
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend (#29519)``
Review Comment:
We can not
The process of release look for exact match between commit title and changelog. this is also why we can not manually fix typos :(
What we can do if you feel we need better description here is to add more free text above this line (like we do for breaking changes). Do you have something in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1123558759
##########
airflow/providers/mysql/CHANGELOG.rst:
##########
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
Changelog
---------
+4.0.2
+.....
+
+Misc
+~~~~
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend (#29519)``
Review Comment:
Oh, well that's a serious bummer. Commit messages aren't necessarily good changelog entries. We should look at loosening that to look for the PR number instead to correlate.
I don't think it's worth doing anything extra for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1123417066
##########
airflow/providers/mysql/CHANGELOG.rst:
##########
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
Changelog
---------
+4.0.2
+.....
+
+Misc
+~~~~
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend (#29519)``
Review Comment:
I wonder if we should reword this. The provider specific change was simply to set the dependencies regardless of arch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1123452723
##########
airflow/providers/mysql/CHANGELOG.rst:
##########
@@ -27,6 +27,14 @@ used with MySQL server 5.6.4 through 5.7.
Changelog
---------
+4.0.2
+.....
+
+Misc
+~~~~
+
+* ``Use MariaDB client binaries in arm64 image for support MySQL backend (#29519)``
Review Comment:
We can not :(
The mechanisem of release look for exact match between commit title and changelog. this is also why we can not manually fix typos :(
What we can do if you feel we need better description here is to add more free text above this line (like we do for breaking changes). Do you have something in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #29878:
URL: https://github.com/apache/airflow/pull/29878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #29878: Prepare docs for 03/2023 wave of Providers
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #29878:
URL: https://github.com/apache/airflow/pull/29878#discussion_r1124392745
##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -24,6 +24,35 @@
Changelog
---------
+7.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``add num rows affected to Redshift Data API hook (#29797)``
+* ``Add 'wait_for_completion' param in 'RedshiftCreateClusterOperator' (#29657)``
+* ``Add Amazon Redshift-data to S3<>RS Transfer Operators (#27947)``
+* ``Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters (#29580)``
+* ``Implement file credentials provider for AWS hook AssumeRoleWithWebIdentity (#29623)``
+* ``Implement custom boto waiters for some EMR operators (#29822)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``fix code checking job names in sagemaker (#29245)``
+* ``Avoid emitting fallback message for S3TaskHandler if streaming logs (#29708)``
+* ``Fix Amazon ECS Enums (#29871)``
+
+Misc
+~~~~
+
+* ``Impovements for RedshiftDataOperator: better error reporting and an ability to return SQL results (#29434)``
+* ``Use waiters in ECS Operators instead of inner sensors (#29761)``
Review Comment:
I can hide entries from the change log if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org