You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2024/03/18 11:19:13 UTC
[PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Roiocam opened a new pull request, #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206
# Effect
## ICON
<img width="271" alt="截屏2024-03-18 19 18 13" src="https://github.com/apache/incubator-pekko/assets/26020358/3e51053b-e0c0-4e62-ba09-65fbabe579f0">
<img width="274" alt="截屏2024-03-18 19 18 27" src="https://github.com/apache/incubator-pekko/assets/26020358/e310918b-7435-448e-b6f1-0f1a655242e5">
## Issue navigation
<img width="375" alt="截屏2024-03-18 19 18 22" src="https://github.com/apache/incubator-pekko/assets/26020358/5e26cdce-6d35-48a6-9d5c-8701a4a92c87">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2005011289
Ok - I think I understand this now. The description has zero description and is very confusing. I thought this was about updating the web site to add a button to support IntelliJ.
It seems that this is actually instead about adding IntelliJ config files. You know that the links that are in our md files actually have the full URLs.
Links look like this in our `.md` files.
```
[Link Name](https://host.name/path/to)
```
Why can't IntelliJ just use the links in the md files? Why do we need to check-in config files with regexs to form URLs? -- the URLs are already in the `.md` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2004946393
I haven't yet had time to test this. I would like to know why this is not in https://github.com/apache/incubator-pekko-sbt-paradox - why would we want to copy this javascript into every single Pekko repo instead of putting the code in a central place that can be reused in different repos?
I still think this should be discussed in an dev@pekko.apache.org mail thread before we invest more time in it.
I don't see why the 'Edit this Page' functionality on pages like https://pekko.apache.org/docs/pekko/current/typed/actor-lifecycle.html is not enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2011512944
I think this is useful, even scala/scala has IDE-specified files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2008738648
> I added this locally, which is indeed useful. But adding the idea folder to the project does indeed violate Apache style. We can add `.idea` folder rule to the ignore file, then we can add a developer tool page in our website, which providing some suggestions from developers, including this setting and some plugins in idea.
>
> Look at this pages, it is very useful. https://spark.apache.org/developer-tools.html
Y
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2005605914
> Why can't IntelliJ just use the links in the md files? Why do we need to check-in config files with regexs to form URLs? -- the URLs are already in the .md file.
This PR provide Two presets:
- display project icon
- generate issue navagation(link) on version control UI.
It doesn't relate to markdown files. If the contributor wants to check the context of some of the commits, through this PR, he can jump directly by clicking the ISSUE number on VCS.
VSCode already provides this feature via the git lens extension.
But there is also an issue with this PR, that is, it doesn't distinguish the ISSUE number from Akka committed before.
## IntelliJ IDEA settings
<img width="380" alt="截屏2024-03-19 09 43 49" src="https://github.com/apache/incubator-pekko/assets/26020358/3de541d1-70e8-4b00-a17a-1d310042adbd">
<img width="728" alt="截屏2024-03-19 09 44 01" src="https://github.com/apache/incubator-pekko/assets/26020358/e9e5bf99-c5f2-4158-841d-b30fb62e223d">
## VSCode extension
<img width="472" alt="截屏2024-03-19 09 54 09" src="https://github.com/apache/incubator-pekko/assets/26020358/1c6a8ace-86e3-494b-ab2f-d45d0185a127">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2003705169
Why do we need this? ASF is vendor neutral. I think we need a mailing list discussion. Please don't merge this until we get 1.1.0-M1 released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2006866061
I added this locally, which is indeed useful. But adding the idea folder to the project does indeed violate Apache style.
We can add `.idea` folder rule to the ignore file, then we can add a developer tool page in our website, which providing some suggestions from developers, including this setting and some plugins in idea.
Look at this pages, it is very useful.
https://spark.apache.org/developer-tools.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed pull request #1206: Add icon, issue navigation in Intellij IDEA and Toolbox
URL: https://github.com/apache/incubator-pekko/pull/1206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2006297159
> In principle I am also against putting IDE specific functionality into the main repo's. Pekko should be entirely IDE/editor agnostic and if we go down this road then we end up polluting the codebase with all of these bespoke editor/IDE workarounds.
I don't feel so strongly about this: while on the one hand adding this to every pekko repo adds some noise, if it improves the contributor experience (esp. for casual/new contributors) it might be worth it.
> for the ZIO ecosystem there is actually an [Intellij ZIO plugin](https://plugins.jetbrains.com/plugin/13820-zio-for-intellij) which also adds a lot of niceties for example better error/compilation hints and inspections/refactorings, we can do the same with Pekko (including solving this issue)
It seems this is a plugin for working *with* ZIO rather than working *on* ZIO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2006272076
In principle I am also against putting IDE specific functionality into the main repo's. Pekko should be entirely IDE/editor agnostic and if we go down this road then we end up polluting the codebase with all of these bespoke editor/IDE workarounds.
We have had these kind of PRs in the past with my response being the same, and although it might be a bit drastic/crazy I think the best solution to this would be a separate Intellij plugin which adds all of these bells and whistles for Pekko projects. Note that I am not alone in this, i.e. for the ZIO ecosystem there is actually an [Intellij ZIO plugin](https://plugins.jetbrains.com/plugin/13820-zio-for-intellij) which also adds a lot of niceties for example better error/compilation hints and inspections/refactorings, we can do the same with Pekko (including solving this issue)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2006326476
> It seems this is a plugin for working _with_ ZIO rather than working _on_ ZIO.
I was more illustrating that the idiomatic way to solve this issue is with separate plugins (and afaik Intellij Plugins can pretty much do anything) even if its just for Pekko developers (and such a hypothetical plugin can do both anyways)
In any case there appears to be issues with the PR, there also may be existing Intellij plugins (i.e. a github one?) which we can document that solves this more comprehensively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add icon, issue navigation in Intellij IDEA and Toolbox [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1206:
URL: https://github.com/apache/incubator-pekko/pull/1206#issuecomment-2004205895
> If this calls non ASF links without user consent then it is banned by ASF rules.
I can't quite understand this. This PR is just a pre-set for developers in IntelliJ IDEA. I have seen the Apache flink already provide this, so maybe this will not be banned by ASF rules.
Anyway, I'm open about whether to provide presets. In some ways, it can improve the developer experience, but on the other hand, it requires some small maintenance costs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org