You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/17 16:47:04 UTC

[GitHub] [airflow] mik-laj edited a comment on pull request #9338: Get API request limit and offset from parameters.py

mik-laj edited a comment on pull request #9338:
URL: https://github.com/apache/airflow/pull/9338#issuecomment-645486285


   @OmairK Rate limit is another problem that can be solved on a different layer, e.g. Load Balancer, so we don't have to deal with it for now.
   
   @ephraimbuddy @svetli-n We should have a limit that should be configured in `airflow.cfg`, but for now we can set it as a fixed value - 100. 
   
   This is to protect against a DOS attack. Fetching one billion records into memory can cause all server memory to be consumed. This problem will not occur if the user fetches only a subset of items in one request. 
   
   It also protects against the lazy programmer. A lazy programmer can give a very high value if he wants to fetch all the items, which can cause instability of the system,. This is related to the previous point, but the reason is slightly different, but it will not be caused by the deliberate action of a person, but by laziness.
   
   What do you think about it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org