You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/04/09 09:17:23 UTC
[GitHub] [cassandra] jacek-lewandowski opened a new pull request #956: CASSANDRA-16497: Fix LongSharedExecutorPoolTest
jacek-lewandowski opened a new pull request #956:
URL: https://github.com/apache/cassandra/pull/956
There were two problems in this test. First is that what is called 'timeout' has a 'deadline'
semantics which means that it is a point in time rather than a duration. However in one place
it was used as a timeout, thus everything got confused at some point and the actual deadlines
turned out to be negative.
The other problem was that with some probability we choose a deadline as Long.MAX_VALUE.
After that, we call Future.get with the corresponding timeout - the timeout is calculated by
subtracting System.nanotime from our deadline (which is Long.MAX_VALUE). However, Future.get
internally adds back System.nanotime to the timeout and passed that to some internal method
await. The problem is that, between subtracting System.nanotime and adding it back, some
time elapses and the second call to System.nanotime returns a larger value, thus the deadline
calculated internally in Future.get overflows the long domain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jacek-lewandowski closed pull request #956: CASSANDRA-16497: Fix LongSharedExecutorPoolTest
Posted by GitBox <gi...@apache.org>.
jacek-lewandowski closed pull request #956:
URL: https://github.com/apache/cassandra/pull/956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org