You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/11/10 14:16:05 UTC
[GitHub] [ozone] jyotirmoy-gh opened a new pull request, #3946: HDDS-7452. [snapshot] Add unit-testcases for snapshot create validation.
jyotirmoy-gh opened a new pull request, #3946:
URL: https://github.com/apache/ozone/pull/3946
## What changes were proposed in this pull request?
Added unit testcase for create snapshot validation - `TestOmSnapshot / testDummyBucket`
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7452
## How was this patch tested?
Added testcases in file - hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
`mvn -Dtest=TestOmSnapshot test`
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.ozone.om.TestOmSnapshot
[INFO] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 156.251 s - in org.apache.hadoop.ozone.om.TestOmSnapshot
[ERROR] Exception in thread "Thread-1021" Exception in thread "Thread-2642" Exception in thread "Thread-2926" Exception in thread "Thread-4261" Exception in thread "Thread-4642"
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on a diff in pull request #3946: HDDS-7452. [snapshot] Add unit-testcases for snapshot create validation.
Posted by GitBox <gi...@apache.org>.
sadanand48 commented on code in PR #3946:
URL: https://github.com/apache/ozone/pull/3946#discussion_r1020105434
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java:
##########
@@ -412,6 +413,20 @@ public void testListAddNewKey()
}
+ @Test
+ public void testNonExistentBucket()
+ throws Exception {
+ String volume = "vol-" + RandomStringUtils.randomNumeric(5);
+ String bucket = "buc-" + RandomStringUtils.randomNumeric(5);
+ //create volume but not bucket
+ store.createVolume(volume);
+ OzoneVolume vol = store.getVolume(volume);
Review Comment:
`M D DLS: Dead store to vol in org.apache.hadoop.ozone.om.TestOmSnapshot.testNonExistentBucket() At TestOmSnapshot.java:[line 423]` , This line can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 merged pull request #3946: HDDS-7452. [snapshot] Add unit-testcases for snapshot create validation.
Posted by GitBox <gi...@apache.org>.
sadanand48 merged PR #3946:
URL: https://github.com/apache/ozone/pull/3946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jyotirmoy-gh commented on pull request #3946: HDDS-7452. [snapshot] Add unit-testcases for snapshot create validation.
Posted by GitBox <gi...@apache.org>.
jyotirmoy-gh commented on PR #3946:
URL: https://github.com/apache/ozone/pull/3946#issuecomment-1310353346
@nilotpalnandi @sadanand48 @smengcl - Please review this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a diff in pull request #3946: HDDS-7452. [snapshot] Add unit-testcases for snapshot create validation.
Posted by GitBox <gi...@apache.org>.
smengcl commented on code in PR #3946:
URL: https://github.com/apache/ozone/pull/3946#discussion_r1019269278
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java:
##########
@@ -412,6 +413,20 @@ public void testListAddNewKey()
}
+ @Test
+ public void testDummyBucket()
Review Comment:
```suggestion
public void testNonExistentBucket()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jyotirmoy-gh commented on a diff in pull request #3946: HDDS-7452. [snapshot] Add unit-testcases for snapshot create validation.
Posted by GitBox <gi...@apache.org>.
jyotirmoy-gh commented on code in PR #3946:
URL: https://github.com/apache/ozone/pull/3946#discussion_r1019300455
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java:
##########
@@ -412,6 +413,20 @@ public void testListAddNewKey()
}
+ @Test
+ public void testDummyBucket()
Review Comment:
Renamed to testNonExistentBucket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jyotirmoy-gh commented on a diff in pull request #3946: HDDS-7452. [snapshot] Add unit-testcases for snapshot create validation.
Posted by GitBox <gi...@apache.org>.
jyotirmoy-gh commented on code in PR #3946:
URL: https://github.com/apache/ozone/pull/3946#discussion_r1020120048
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java:
##########
@@ -412,6 +413,20 @@ public void testListAddNewKey()
}
+ @Test
+ public void testNonExistentBucket()
+ throws Exception {
+ String volume = "vol-" + RandomStringUtils.randomNumeric(5);
+ String bucket = "buc-" + RandomStringUtils.randomNumeric(5);
+ //create volume but not bucket
+ store.createVolume(volume);
+ OzoneVolume vol = store.getVolume(volume);
Review Comment:
Thanks for pointing it out. Removed the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org