You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/14 04:19:25 UTC
[GitHub] [rocketmq] panzhi33 opened a new pull request #2804: fix the endpoint cannot get instanceId without http
panzhi33 opened a new pull request #2804:
URL: https://github.com/apache/rocketmq/pull/2804
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #2804: [ISSUE #2803] Fix the endpoint cannot get instanceId without http
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #2804:
URL: https://github.com/apache/rocketmq/pull/2804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] panzhi33 commented on pull request #2804: 【#2803】fix the endpoint cannot get instanceId without http
Posted by GitBox <gi...@apache.org>.
panzhi33 commented on pull request #2804:
URL: https://github.com/apache/rocketmq/pull/2804#issuecomment-819216955
#2803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2804: [ISSUE #2803] Fix the endpoint cannot get instanceId without http
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2804:
URL: https://github.com/apache/rocketmq/pull/2804#issuecomment-819245035
[](https://coveralls.io/builds/38801429)
Coverage increased (+0.1%) to 51.96% when pulling **8fdcf1eec996d96baccb76983de23199d423c8dc on panzhi33:release-4.8.0** into **af8a9648c75d3dac5a7e7fcd0d8047d41456d96d on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2804: [ISSUE #2803] Fix the endpoint cannot get instanceId without http
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2804:
URL: https://github.com/apache/rocketmq/pull/2804#issuecomment-819245035
[](https://coveralls.io/builds/38800072)
Coverage increased (+0.1%) to 51.963% when pulling **42b4e327aa3e4e3371a198ac1035196375adc86c on panzhi33:release-4.8.0** into **af8a9648c75d3dac5a7e7fcd0d8047d41456d96d on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #2804: [ISSUE #2803] Fix the endpoint cannot get instanceId without http
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2804:
URL: https://github.com/apache/rocketmq/pull/2804#issuecomment-819338071
It would be better to write a UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a change in pull request #2804: [ISSUE #2803] Fix the endpoint cannot get instanceId without http
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on a change in pull request #2804:
URL: https://github.com/apache/rocketmq/pull/2804#discussion_r613102067
##########
File path: common/src/test/java/org/apache/rocketmq/common/utils/NameServerAddressUtilsTest.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.common.utils;
+
+import org.junit.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class NameServerAddressUtilsTest {
+
+ private static String endpoint1 = "http://127.0.0.1:9876";
+ private static String endpoint2 = "127.0.0.1:9876";
+ private static String endpoint3
+ = "http://MQ_INST_123456789_BXXUzaee.mq-internet-access.mq-internet.aliyuncs.com:80";
+ private static String endpoint4 = "MQ_INST_123456789_BXXUzaee.mq-internet-access.mq-internet.aliyuncs.com:80";
Review comment:
It would be better not appear the words like ‘aliyun’
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2804: [ISSUE #2803] Fix the endpoint cannot get instanceId without http
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2804:
URL: https://github.com/apache/rocketmq/pull/2804#issuecomment-819245035
[](https://coveralls.io/builds/38802131)
Coverage increased (+0.01%) to 51.825% when pulling **d45f18bca5badbdfac9f3f56996b9c7fe1e1ad4f on panzhi33:release-4.8.0** into **af8a9648c75d3dac5a7e7fcd0d8047d41456d96d on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2804: 【#2803】fix the endpoint cannot get instanceId without http
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2804:
URL: https://github.com/apache/rocketmq/pull/2804#issuecomment-819245035
[](https://coveralls.io/builds/38794827)
Coverage increased (+0.01%) to 51.825% when pulling **89f8ecc4ad533422fe368435f4d59ff56625a6c3 on panzhi33:release-4.8.0** into **af8a9648c75d3dac5a7e7fcd0d8047d41456d96d on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org