You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/11/07 19:39:00 UTC

[GitHub] [incubator-tvm] csarofeen edited a comment on issue #4270: [Codgen] Thread variable use before define

csarofeen edited a comment on issue #4270: [Codgen] Thread variable use before define
URL: https://github.com/apache/incubator-tvm/pull/4270#issuecomment-551229481
 
 
   That is a reasonable suggestion, the issue is it does prevent being able to construct certain loops. I've gone back and forth a few times on this and have 2 issues with taking that approach.
   1) I don't know why this shouldn't be considered a legal schedule. If we prevent construction like this, I think it puts more difficulty on users to generate legal schedules.
   2) This stems from code that was intending to do a fast gemm tiling which looks like: smem tile load -> local tile load -> local compute -> gmem store. This with another change (I'm not liking that change, and am uncertain if there's a better way to do it) allowed me to make that situation work but I couldn't find another equivalent schedule that would work. 
   
   Had one more thought. Instead of making this an error, why wouldn't we relax this case in the bounds inference? It makes life more manual in that instance as we may have to rebind the same thread to different axis many times, but at least it isn't an error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services