You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Tao Feng (JIRA)" <ji...@apache.org> on 2016/03/05 07:43:40 UTC
[jira] [Commented] (SAMZA-887) Use cached JobModel everywhere in
the Samza AM container
[ https://issues.apache.org/jira/browse/SAMZA-887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181577#comment-15181577 ]
Tao Feng commented on SAMZA-887:
--------------------------------
https://reviews.apache.org/r/44418/
> Use cached JobModel everywhere in the Samza AM container
> --------------------------------------------------------
>
> Key: SAMZA-887
> URL: https://issues.apache.org/jira/browse/SAMZA-887
> Project: Samza
> Issue Type: Bug
> Reporter: Navina Ramesh
>
> Since the CoordinatorStreamConsumer is inefficient in how it stays up-to-date with the coordinator stream, it is not acceptable to call jobcoordinator.jobModel() to access the jobmodel within the AM container. This will trigger a "refreshJobModel" on each access. Instead, we should be using cached job model's reference (JobCoordinator.jobModelRef) to access the config.
> As of today, this incorrect access pattern can be seen StreamAppender.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)