You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/12/04 00:00:04 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4877: Results in
ResultTable if responseFormat=sql
codecov-io commented on issue #4877: Results in ResultTable if responseFormat=sql
URL: https://github.com/apache/incubator-pinot/pull/4877#issuecomment-561412213
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4877?src=pr&el=h1) Report
> Merging [#4877](https://codecov.io/gh/apache/incubator-pinot/pull/4877?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/3ec7548cd1a5abbebd32cb2fc28fdd229e47a2fa?src=pr&el=desc) will **increase** coverage by `13.9%`.
> The diff coverage is `85.78%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4877?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4877 +/- ##
===========================================
+ Coverage 36% 49.9% +13.9%
- Complexity 0 4 +4
===========================================
Files 1207 1174 -33
Lines 64756 62687 -2069
Branches 9407 9201 -206
===========================================
+ Hits 23316 31287 +7971
+ Misses 39371 28973 -10398
- Partials 2069 2427 +358
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4877?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/core/query/selection/SelectionOperatorUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vU2VsZWN0aW9uT3BlcmF0b3JVdGlscy5qYXZh) | `88.92% <100%> (+23.16%)` | `0 <0> (ø)` | :arrow_down: |
| [...core/query/selection/SelectionOperatorService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vU2VsZWN0aW9uT3BlcmF0b3JTZXJ2aWNlLmphdmE=) | `95.38% <100%> (+2.93%)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/core/query/reduce/DistinctDataTableReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvRGlzdGluY3REYXRhVGFibGVSZWR1Y2VyLmphdmE=) | `67.74% <56.52%> (-4.36%)` | `0 <0> (ø)` | |
| [...t/core/query/reduce/SelectionDataTableReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvU2VsZWN0aW9uRGF0YVRhYmxlUmVkdWNlci5qYXZh) | `55.17% <58.82%> (-14.4%)` | `0 <0> (ø)` | |
| [...core/query/reduce/AggregationDataTableReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQWdncmVnYXRpb25EYXRhVGFibGVSZWR1Y2VyLmphdmE=) | `83.33% <90.32%> (-2.78%)` | `0 <0> (ø)` | |
| [...not/core/query/reduce/GroupByDataTableReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvR3JvdXBCeURhdGFUYWJsZVJlZHVjZXIuamF2YQ==) | `84.06% <92.23%> (+50.73%)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/pinot/common/metrics/BrokerQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJRdWVyeVBoYXNlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...g/apache/pinot/sql/parsers/CalciteSqlCompiler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsQ29tcGlsZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...pache/pinot/core/realtime/stream/MessageBatch.java](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9zdHJlYW0vTWVzc2FnZUJhdGNoLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | |
| ... and [738 more](https://codecov.io/gh/apache/incubator-pinot/pull/4877/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4877?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4877?src=pr&el=footer). Last update [3ec7548...054da2d](https://codecov.io/gh/apache/incubator-pinot/pull/4877?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org