You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by an...@apache.org on 2007/04/23 14:27:32 UTC

svn commit: r531447 - in /lenya/trunk/src: modules/lucene/java/src/org/apache/cocoon/components/search/components/impl/ pubs/default/config/ pubs/default/config/search/

Author: andreas
Date: Mon Apr 23 05:27:22 2007
New Revision: 531447

URL: http://svn.apache.org/viewvc?view=rev&rev=531447
Log:
Remove obsolete index configuration file, moved new index config file to config/search

Added:
    lenya/trunk/src/pubs/default/config/search/lucene_index.xconf
      - copied unchanged from r531356, lenya/trunk/src/pubs/default/config/lucene_index.xconf
Removed:
    lenya/trunk/src/pubs/default/config/lucene_index.xconf
    lenya/trunk/src/pubs/default/config/search/lucene-live.xconf
Modified:
    lenya/trunk/src/modules/lucene/java/src/org/apache/cocoon/components/search/components/impl/IndexManagerImpl.java

Modified: lenya/trunk/src/modules/lucene/java/src/org/apache/cocoon/components/search/components/impl/IndexManagerImpl.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules/lucene/java/src/org/apache/cocoon/components/search/components/impl/IndexManagerImpl.java?view=diff&rev=531447&r1=531446&r2=531447
==============================================================================
--- lenya/trunk/src/modules/lucene/java/src/org/apache/cocoon/components/search/components/impl/IndexManagerImpl.java (original)
+++ lenya/trunk/src/modules/lucene/java/src/org/apache/cocoon/components/search/components/impl/IndexManagerImpl.java Mon Apr 23 05:27:22 2007
@@ -123,7 +123,7 @@
     /**
      * The name of the index configuration file.
      */
-    public static final String INDEX_CONF_FILE = "lucene_index.xconf";
+    public static final String INDEX_CONF_FILE = "search/lucene_index.xconf";
 
     /**
      * check the config file each time the getIndex is called to update if necessary the



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org

Re: svn commit: r531447 - in /lenya/trunk/src: modules/lucene/java/src/org/apache/cocoon/components/search/components/impl/ pubs/default/config/ pubs/default/config/search/

Posted by Andreas Hartmann <an...@apache.org>.
Joern Nettingsmeier schrieb:
> Andreas Hartmann wrote:
>> Joern Nettingsmeier schrieb:
>>> andreas@apache.org wrote:
>>>> Author: andreas
>>>> Date: Mon Apr 23 05:27:22 2007
>>>> New Revision: 531447
>>>>
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=531447
>>>> Log:
>>>> Remove obsolete index configuration file, moved new index config file
>>>> to config/search
>>>>
>>> since the module is called "lucene" and the search configuration is
>>> lucene-specific, i think that the subdirectory should be config/lucene.
>>> wdyt?
>>
>> That would certainly be cleaner from a developer's point of view, but
>> IMO the entry barrier is lower when we call it "search".
> 
> good point. i just wonder what might happen if we have more modules in
> the future with per-publication configuration settings...

Good point as well. Maybe we should use

  $PUB_HOME/config/modules/<module-id>/...

What do the others think?

-- Andreas


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org

Re: svn commit: r531447 - in /lenya/trunk/src: modules/lucene/java/src/org/apache/cocoon/components/search/components/impl/ pubs/default/config/ pubs/default/config/search/

Posted by Joern Nettingsmeier <ne...@folkwang-hochschule.de>.
Andreas Hartmann wrote:
> Joern Nettingsmeier schrieb:
>> andreas@apache.org wrote:
>>> Author: andreas
>>> Date: Mon Apr 23 05:27:22 2007
>>> New Revision: 531447
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=531447
>>> Log:
>>> Remove obsolete index configuration file, moved new index config file
>>> to config/search
>>>
>> since the module is called "lucene" and the search configuration is
>> lucene-specific, i think that the subdirectory should be config/lucene.
>> wdyt?
> 
> That would certainly be cleaner from a developer's point of view, but
> IMO the entry barrier is lower when we call it "search".

good point. i just wonder what might happen if we have more modules in 
the future with per-publication configuration settings...

well, just a side issue anyways.


-- 
jörn nettingsmeier

home://germany/45128 essen/lortzingstr. 11/
http://spunk.dnsalias.org
phone://+49/201/491621

Kurt is up in Heaven now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org

Re: svn commit: r531447 - in /lenya/trunk/src: modules/lucene/java/src/org/apache/cocoon/components/search/components/impl/ pubs/default/config/ pubs/default/config/search/

Posted by Andreas Hartmann <an...@apache.org>.
Joern Nettingsmeier schrieb:
> andreas@apache.org wrote:
>> Author: andreas
>> Date: Mon Apr 23 05:27:22 2007
>> New Revision: 531447
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=531447
>> Log:
>> Remove obsolete index configuration file, moved new index config file
>> to config/search
>>
> 
> since the module is called "lucene" and the search configuration is
> lucene-specific, i think that the subdirectory should be config/lucene.
> wdyt?

That would certainly be cleaner from a developer's point of view, but
IMO the entry barrier is lower when we call it "search".

-- Andreas


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org

Re: svn commit: r531447 - in /lenya/trunk/src: modules/lucene/java/src/org/apache/cocoon/components/search/components/impl/ pubs/default/config/ pubs/default/config/search/

Posted by Joern Nettingsmeier <ne...@folkwang-hochschule.de>.
andreas@apache.org wrote:
> Author: andreas
> Date: Mon Apr 23 05:27:22 2007
> New Revision: 531447
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=531447
> Log:
> Remove obsolete index configuration file, moved new index config file to config/search
> 

since the module is called "lucene" and the search configuration is 
lucene-specific, i think that the subdirectory should be config/lucene. 
wdyt?


-- 
jörn nettingsmeier

home://germany/45128 essen/lortzingstr. 11/
http://spunk.dnsalias.org
phone://+49/201/491621

Kurt is up in Heaven now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org