[GitHub] [superset] villebro commented on a change in pull request #17593: feat: Trino Authentications

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #17593:
URL: https://github.com/apache/superset/pull/17593#discussion_r784754891



##########
File path: superset/config.py
##########
@@ -986,6 +989,9 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC(  # pylint: disable=invalid-name
 # See here: https://github.com/dropbox/PyHive/blob/8eb0aeab8ca300f3024655419b93dad926c1a351/pyhive/presto.py#L93  # pylint: disable=line-too-long,useless-suppression
 PRESTO_POLL_INTERVAL = int(timedelta(seconds=1).total_seconds())
 
+# A list of custom Trino authentication that allowed.
+TRINO_EXTRA_AUTHENTICATION: List[str] = []

Review comment:
       To avoid cluttering the config with engine-specific props, could we make this similar to how `TIME_GRAIN_ADDON_EXPRESSIONS` is defined, where we have a `dict` with the engine name as a key. Something like
   
   ```python
   ALLOWED_EXTRA_AUTHENTICATIONS: Dict[str, List[str]] = {}
   ```
   
   Then when you implement these, it would be
   
   ```python
   ALLOWED_EXTRA_AUTHENTICATIONS: Dict[str, List[str[]] = {
       "trino": [
           "<your.module:AuthClass>",
           "<another.extra:auth_method>",
       ],
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org