You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/08/10 23:41:16 UTC
Review Request 61588: Added a `--skip-style-check` option when
applying reviews.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
Bugs: MESOS-7880
https://issues.apache.org/jira/browse/MESOS-7880
Repository: mesos
Description
-------
Added a `--skip-style-check` option when applying reviews.
Diffs
-----
support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
Diff: https://reviews.apache.org/r/61588/diff/1/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when
applying reviews.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review182765
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61588]
Logs available here: http://104.210.40.105/logs/master/61588
- Mesos Reviewbot Windows
On Aug. 11, 2017, 2:03 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 2:03 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7880
> https://issues.apache.org/jira/browse/MESOS-7880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `[-s|--skip-hooks]` option when applying reviews.
>
>
> Diffs
> -----
>
> support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
>
>
> Diff: https://reviews.apache.org/r/61588/diff/3/
>
>
> Testing
> -------
>
> Applied a review chain.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when
applying reviews.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/
-----------------------------------------------------------
(Updated Aug. 23, 2017, 6:35 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
Changes
-------
Addressed Andrew's comment.
Bugs: MESOS-7880
https://issues.apache.org/jira/browse/MESOS-7880
Repository: mesos
Description
-------
Added a `[-s|--skip-hooks]` option when applying reviews.
Diffs (updated)
-----
support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
Diff: https://reviews.apache.org/r/61588/diff/4/
Changes: https://reviews.apache.org/r/61588/diff/3-4/
Testing
-------
Applied a review chain.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when
applying reviews.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review183393
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61588]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 11, 2017, 2:03 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 2:03 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7880
> https://issues.apache.org/jira/browse/MESOS-7880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `[-s|--skip-hooks]` option when applying reviews.
>
>
> Diffs
> -----
>
> support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
>
>
> Diff: https://reviews.apache.org/r/61588/diff/3/
>
>
> Testing
> -------
>
> Applied a review chain.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when
applying reviews.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review183270
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
support/apply-reviews.py
Line 209 (original), 209 (patched)
<https://reviews.apache.org/r/61588/#comment259284>
As long as we're fixing things, `GitHub` :)
- Andrew Schwartzmeyer
On Aug. 11, 2017, 2:03 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 2:03 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7880
> https://issues.apache.org/jira/browse/MESOS-7880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `[-s|--skip-hooks]` option when applying reviews.
>
>
> Diffs
> -----
>
> support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
>
>
> Diff: https://reviews.apache.org/r/61588/diff/3/
>
>
> Testing
> -------
>
> Applied a review chain.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when
applying reviews.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/
-----------------------------------------------------------
(Updated Aug. 11, 2017, 9:03 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
Changes
-------
Addressed @bbannier's comments and made the program pass the style check.
Bugs: MESOS-7880
https://issues.apache.org/jira/browse/MESOS-7880
Repository: mesos
Description
-------
Added a `[-s|--skip-hooks]` option when applying reviews.
Diffs (updated)
-----
support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
Diff: https://reviews.apache.org/r/61588/diff/3/
Changes: https://reviews.apache.org/r/61588/diff/2-3/
Testing (updated)
-------
Applied a review chain.
Thanks,
Chun-Hung Hsiao
Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when
applying reviews.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review182745
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61588]
Logs available here: http://104.210.40.105/logs/master/61588
- Mesos Reviewbot Windows
On Aug. 11, 2017, 6:45 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 6:45 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7880
> https://issues.apache.org/jira/browse/MESOS-7880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `[-s|--skip-hooks]` option when applying reviews.
>
>
> Diffs
> -----
>
> support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
>
>
> Diff: https://reviews.apache.org/r/61588/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when
applying reviews.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review182742
-----------------------------------------------------------
Fix it, then Ship it!
Thanks for the patch. I am sure this will be very useful for e.g., reviewing patches currently not passing the our linters.
support/apply-reviews.py
Lines 263-266 (original), 269-273 (patched)
<https://reviews.apache.org/r/61588/#comment258731>
This line extends beyond 80 chars. Let's wrap it to not undo already done work for MESOS-6390, e.g.,
cmd = u"git commit "\
"--author \"{author}\" "\
"{amend} -aF \"{message}\" {verify}".format(
author=quote(data['author']),
amend=amend,
message=message_file,
verify=verify)
(We seem to prefer C-style continuations to the more usual triple quotes).
Note how the args to `format` are indented by 4 spaces relative to the wrapped string.
To check if the format passes the still not enabled linting of support Python scripts, add `support` to `PyLinter`'s `source_dirs` in `support/mesos-style.py`, and run it on the file.
- Benjamin Bannier
On Aug. 11, 2017, 8:45 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 8:45 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7880
> https://issues.apache.org/jira/browse/MESOS-7880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `[-s|--skip-hooks]` option when applying reviews.
>
>
> Diffs
> -----
>
> support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
>
>
> Diff: https://reviews.apache.org/r/61588/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when
applying reviews.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/
-----------------------------------------------------------
(Updated Aug. 11, 2017, 6:45 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
Changes
-------
Addressed @bbannier's comments.
Summary (updated)
-----------------
Added a `[-s|--skip-hooks]` option when applying reviews.
Bugs: MESOS-7880
https://issues.apache.org/jira/browse/MESOS-7880
Repository: mesos
Description (updated)
-------
Added a `[-s|--skip-hooks]` option when applying reviews.
Diffs (updated)
-----
support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
Diff: https://reviews.apache.org/r/61588/diff/2/
Changes: https://reviews.apache.org/r/61588/diff/1-2/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 61588: Added a `--skip-style-check` option when
applying reviews.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On Aug. 11, 2017, 9:02 a.m., Benjamin Bannier wrote:
> > support/apply-reviews.py
> > Line 364 (original), 371-373 (patched)
> > <https://reviews.apache.org/r/61588/diff/1/?file=1795426#file1795426line371>
> >
> > Since this prevents running any (pre-)commit hooks, I wonder if we should give this a more general name, e.g., simply expose `[-n|--no-verify]`.
If we use `--no-verify` a the long option, then the short option `-n` would conflict with `--no-amend`, and it seems to me that we should not change what's already there. And `-v` looks like `--verbose` and also not obvious to see it's *not* doing a verification. Keviv and I looked through the keyboard and came up with this one.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review182670
-----------------------------------------------------------
On Aug. 10, 2017, 11:41 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 11:41 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7880
> https://issues.apache.org/jira/browse/MESOS-7880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `--skip-style-check` option when applying reviews.
>
>
> Diffs
> -----
>
> support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
>
>
> Diff: https://reviews.apache.org/r/61588/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61588: Added a `--skip-style-check` option when
applying reviews.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Aug. 11, 2017, 11:02 a.m., Benjamin Bannier wrote:
> > support/apply-reviews.py
> > Line 364 (original), 371-373 (patched)
> > <https://reviews.apache.org/r/61588/diff/1/?file=1795426#file1795426line371>
> >
> > Since this prevents running any (pre-)commit hooks, I wonder if we should give this a more general name, e.g., simply expose `[-n|--no-verify]`.
>
> Chun-Hung Hsiao wrote:
> If we use `--no-verify` a the long option, then the short option `-n` would conflict with `--no-amend`, and it seems to me that we should not change what's already there. And `-v` looks like `--verbose` and also not obvious to see it's *not* doing a verification. Keviv and I looked through the keyboard and came up with this one.
Good point about collisions. What about e.g., `[-s|--skip-commit-hooks]` or even `[-s|--skip-hooks]`? If I had a precommit hook invoking `clang-format` this flag would also disable it.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review182670
-----------------------------------------------------------
On Aug. 11, 2017, 1:41 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 1:41 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7880
> https://issues.apache.org/jira/browse/MESOS-7880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `--skip-style-check` option when applying reviews.
>
>
> Diffs
> -----
>
> support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
>
>
> Diff: https://reviews.apache.org/r/61588/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61588: Added a `--skip-style-check` option when
applying reviews.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review182670
-----------------------------------------------------------
support/apply-reviews.py
Lines 263-266 (original), 269-273 (patched)
<https://reviews.apache.org/r/61588/#comment258658>
Not yours, but we don't necessarily need to disambiguate the keys we map the values onto, e.g.,
cmd = u'git commit --author \"{author}\" {amend} -aF \"{message}\" {verify}'.format(
author=quote(data['author']),
amend=amend,
message=message_file,
verify=verify)
support/apply-reviews.py
Line 364 (original), 371-373 (patched)
<https://reviews.apache.org/r/61588/#comment258659>
Since this prevents running any (pre-)commit hooks, I wonder if we should give this a more general name, e.g., simply expose `[-n|--no-verify]`.
- Benjamin Bannier
On Aug. 11, 2017, 1:41 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 1:41 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7880
> https://issues.apache.org/jira/browse/MESOS-7880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `--skip-style-check` option when applying reviews.
>
>
> Diffs
> -----
>
> support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
>
>
> Diff: https://reviews.apache.org/r/61588/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 61588: Added a `--skip-style-check` option when
applying reviews.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61588/#review182679
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61588]
Logs available here: http://104.210.40.105/logs/master/61588
- Mesos Reviewbot Windows
On Aug. 10, 2017, 11:41 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61588/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 11:41 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7880
> https://issues.apache.org/jira/browse/MESOS-7880
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `--skip-style-check` option when applying reviews.
>
>
> Diffs
> -----
>
> support/apply-reviews.py aa2eb8d23bed52a4f33510c53ace2c63bd66ec49
>
>
> Diff: https://reviews.apache.org/r/61588/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>