You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/07/29 15:22:57 UTC

[GitHub] [ofbiz-framework] nmalin commented on a change in pull request #317: Clojure engine for OFBiz

nmalin commented on a change in pull request #317:
URL: https://github.com/apache/ofbiz-framework/pull/317#discussion_r679253725



##########
File path: framework/common/servicedef/services.xml
##########
@@ -45,6 +45,10 @@ under the License.
             location="org.apache.ofbiz.common.CommonServices" invoke="echoService">
         <description>Echos back all passed parameters</description>
     </service>
+    <service name="echo-service" engine="clojure" validate="false"

Review comment:
       I suggest to use camel case for the name, like 'echoClojureService'




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org