You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/11/03 03:42:02 UTC
[PR] [CELEBORN-1048][FOLLOWUP] [incubator-celeborn]
cxzl25 opened a new pull request, #2069:
URL: https://github.com/apache/incubator-celeborn/pull/2069
### What changes were proposed in this pull request?
Let the MR module compile successfully.
### Why are the changes needed?
#2000 added parameters in the `ShuffleClient#readPartition` method, resulting in MR module compilation failure.
MR CI is still missing.
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1048][FOLLOWUP] MR module compile [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2069: [CELEBORN-1048][FOLLOWUP] MR module compile
URL: https://github.com/apache/incubator-celeborn/pull/2069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1048][FOLLOWUP] MR module compile [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2069:
URL: https://github.com/apache/incubator-celeborn/pull/2069#issuecomment-1791863345
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2069?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2069](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2069?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (095d20d) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/7b185a2562857b35ae4fd6bed7026ebd616eeda9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7b185a2) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #2069 +/- ##
==========================================
+ Coverage 46.91% 46.93% +0.03%
==========================================
Files 165 165
Lines 10586 10586
Branches 963 963
==========================================
+ Hits 4965 4968 +3
+ Misses 5299 5297 -2
+ Partials 322 321 -1
```
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2069/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org