[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request #1136: HDDS-3798. Collect more info about DN in recon web

[GitBox <gi...@apache.org>]

vivekratnavel commented on a change in pull request #1136:
URL: https://github.com/apache/hadoop-ozone/pull/1136#discussion_r449914992



##########
File path: hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
##########
@@ -201,14 +254,23 @@ export class Datanodes extends React.Component<Record<string, object>, IDatanode
           storageRemaining: datanode.storageReport.remaining,
           pipelines: datanode.pipelines,
           containers: datanode.containers,
-          leaderCount: datanode.leaderCount
+          leaderCount: datanode.leaderCount,
+          version: datanode.version,
+          setupTime: datanode.setupTime
         };
       });
+      const selectedColumns: IOption[] = COLUMNS.filter(column => column.isVisible).map(column => ({
+        label: column.key,
+        value: column.key
+      }))
+      
       this.setState({
         loading: false,
         dataSource,
         totalCount,
-        lastUpdated: Number(moment())
+        lastUpdated: Number(moment()),

Review comment:
       nit: dangling comma
   ```suggestion
           lastUpdated: Number(moment())
   ```

##########
File path: hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
##########
@@ -233,20 +295,48 @@ export class Datanodes extends React.Component<Record<string, object>, IDatanode
   };
 
   render() {
-    const {dataSource, loading, totalCount, lastUpdated} = this.state;
+    const {dataSource, loading, totalCount, lastUpdated, selectedColumns, columnOptions} = this.state;
     const paginationConfig: PaginationConfig = {
       showTotal: (total: number, range) => `${range[0]}-${range[1]} of ${total} datanodes`,
       showSizeChanger: true,
       onShowSizeChange: this.onShowSizeChange
     };
     return (
-      <div className='datanodes-container'>
-        <div className='page-header'>
+      <div className="datanodes-container">
+        <div className="page-header">
           Datanodes ({totalCount})
-          <AutoReloadPanel isLoading={loading} lastUpdated={lastUpdated} togglePolling={this.autoReload.handleAutoReloadToggle} onReload={this._loadData}/>
+          <div className="filter-block">
+            <MultiSelect
+              maxShowValues={3}
+              allowSelectAll
+              isMulti
+              className="multi-select-container"
+              options={columnOptions}
+              closeMenuOnSelect={false}
+              hideSelectedOptions={false}
+              value={selectedColumns}
+              allOption={allColumnsOption}
+              onChange={this._handleColumnChange}
+            /> Columns
+          </div>
+          <AutoReloadPanel
+            isLoading={loading}
+            lastUpdated={lastUpdated}
+            togglePolling={this.autoReload.handleAutoReloadToggle}
+            onReload={this._loadData}
+          />
         </div>
-        <div className='content-div'>
-          <Table dataSource={dataSource} columns={COLUMNS} loading={loading} pagination={paginationConfig} rowKey='hostname'/>
+
+        <div className="content-div">
+          <Table
+            dataSource={dataSource}
+            columns={COLUMNS.filter((column) =>
+              selectedColumns.some((e) => e.label === column.key)

Review comment:
       nit: compare value instead of label
   ```suggestion
                 selectedColumns.some((e) => e.value === column.key)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org