You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/13 03:32:32 UTC
[GitHub] [arrow] paddyhoran opened a new pull request #8656: ARROW-10575: [Rust] Rename union.rs to be cosistent with other arrays
paddyhoran opened a new pull request #8656:
URL: https://github.com/apache/arrow/pull/8656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paddyhoran commented on pull request #8656: ARROW-10575: [Rust] Rename union.rs to be cosistent with other arrays
Posted by GitBox <gi...@apache.org>.
paddyhoran commented on pull request #8656:
URL: https://github.com/apache/arrow/pull/8656#issuecomment-726763619
> The https://github.com/apache/arrow/pull/8656/checks?check_run_id=1394039681 build on travis seems to have been queued for many hours at this point. I am thinking that merging this PR anyways would be fine. Any thoughts?
Yea, I agree. This is a pretty low risk given the nature of the PR and that all the other CI runs were fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #8656: ARROW-10575: [Rust] Rename union.rs to be cosistent with other arrays
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #8656:
URL: https://github.com/apache/arrow/pull/8656#discussion_r522898144
##########
File path: rust/arrow/src/array/mod.rs
##########
@@ -121,8 +121,8 @@ pub use self::array_primitive::PrimitiveArray;
pub use self::array_string::LargeStringArray;
pub use self::array_string::StringArray;
pub use self::array_struct::StructArray;
+pub use self::array_union::UnionArray;
Review comment:
👍
Looks like we could also do the same thing (move `NullArray` from `null.rs` to `null_array.rs`), though as a different PR. I think this PR is a good improvement itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #8656: ARROW-10575: [Rust] Rename union.rs to be cosistent with other arrays
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #8656:
URL: https://github.com/apache/arrow/pull/8656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8656: ARROW-10575: [Rust] Rename union.rs to be cosistent with other arrays
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8656:
URL: https://github.com/apache/arrow/pull/8656#issuecomment-726759319
The https://github.com/apache/arrow/pull/8656/checks?check_run_id=1394039681 build on travis seems to have been queued for many hours at this point. I am thinking that merging this PR anyways would be fine. Any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8656: ARROW-10575: [Rust] Rename union.rs to be cosistent with other arrays
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8656:
URL: https://github.com/apache/arrow/pull/8656#issuecomment-726490144
https://issues.apache.org/jira/browse/ARROW-10575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org