You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/14 11:15:10 UTC

[GitHub] [flink] twalthr commented on pull request #12130: [FLINK-17668][table] Fix shortcomings in new data structures

twalthr commented on pull request #12130:
URL: https://github.com/apache/flink/pull/12130#issuecomment-628565405


   Thanks for sharing your benchmark results @wuchong. I also performed additional benchmarks. What I didn't like in your branch is the little data size, I don't know if the JIT compiler can already kick in. I tried to perform a more realistic benachmark on the current branch. See:
   https://github.com/twalthr/flink/tree/FLINK-16999_BENCHMARKS
   
   The results didn't make a big difference:
   ```
   # Run complete. Total time: 00:09:56
   Benchmark                         Mode  Cnt  Score    Error   Units
   RowAccessBenchmark.testAccessor  thrpt   50  0.003 ±  0.001  ops/ms
   RowAccessBenchmark.testGetter    thrpt   50  0.003 ±  0.001  ops/ms
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org