You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by solomax <gi...@git.apache.org> on 2017/04/10 07:23:12 UTC
[GitHub] wicket pull request #218: [WICKET-6354] string constants and references are ...
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/218
[WICKET-6354] string constants and references are added for all versi\u2026
\u2026ons of jquery
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/solomax/wicket master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #218
----
commit dbfe141da0f447d86d4174c56454fe61cbe545f4
Author: Maxim Solodovnik <so...@gmail.com>
Date: 2017-04-10T07:22:02Z
[WICKET-6354] string constants and references are added for all versions of jquery
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #218: [WICKET-6354] string constants and references are added f...
Posted by sebfz1 <gi...@git.apache.org>.
Github user sebfz1 commented on the issue:
https://github.com/apache/wicket/pull/218
There is/was already a `VERSION_2` in `DynamicJQueryResourceReference`.
I think only one should be kept...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #218: [WICKET-6354] string constants and references are ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #218: [WICKET-6354] string constants and references are added f...
Posted by solomax <gi...@git.apache.org>.
Github user solomax commented on the issue:
https://github.com/apache/wicket/pull/218
It actually was my plan
But I was trying to keep changes minimal, hoping wicket team can polish it
I guess some test that ensures VERSION_* is updated with jquery update are required ....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #218: [WICKET-6354] string constants and references are added f...
Posted by sebfz1 <gi...@git.apache.org>.
Github user sebfz1 commented on the issue:
https://github.com/apache/wicket/pull/218
My bad, you used it! ;)
Then opened question: why not centralize all in `JQueryResourceReference`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---