[GitHub] [ozone] myskov commented on a diff in pull request #3547: HDDS-6940. EC: Skip the EC container for balancer

[GitBox <gi...@apache.org>]

myskov commented on code in PR #3547:
URL: https://github.com/apache/ozone/pull/3547#discussion_r906315309


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerSelectionCriteria.java:
##########
@@ -136,6 +140,19 @@ public NavigableSet<ContainerID> getCandidateContainers(
     });
 
     containerIDSet.removeIf(this::isContainerReplicatingOrDeleting);
+
+    // remove EC containers
+    containerIDSet.removeIf(containerID -> {
+      try {

Review Comment:
   Wouldn't it be cleaner to move the try-catch block from lambda to the isECContainer() method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org