[GitHub] [spark] Ngone51 commented on a change in pull request #32287: [SPARK-27991][CORE] Defer the fetch request on Netty OOM

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #32287:
URL: https://github.com/apache/spark/pull/32287#discussion_r618541639



##########
File path: common/network-common/src/main/java/org/apache/spark/network/util/NettyUtils.java
##########
@@ -37,6 +37,14 @@
  */
 public class NettyUtils {
 
+  /**
+   * A flag which indicates whether the Netty OOM error has raised during shuffle.
+   * If true, unless there's no in-flight fetch requests, all the pending shuffle
+   * fetch requests will be deferred until the flag is unset (whenever there's a
+   * complete fetch request).
+   */
+  public static volatile boolean isNettyOOMOnShuffle = false;

Review comment:
       I can make it but just wondering is it necessary? Because I think the operation (read/write) on `boolean` is already atomic.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org