You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/06/09 13:31:36 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #24341: fix: Viz migration adjustments - 1
michael-s-molina opened a new pull request, #24341:
URL: https://github.com/apache/superset/pull/24341
### SUMMARY
Makes adjustments to the viz migrations to fix problems found during tests.
- Adjusts the Pivot Table migration to account only for the column totals instead of rows and columns given that the legacy chart didn't support row totals.
- Adjusts the Pivot Table to sort the rows by descending values given that this was the original algorithm in the legacy version.
- Adjusts the Dual Line migration to account for the `GENERIC_CHART_AXES` feature flag.
- Adjusts migrations that contain a X-axis control to set the time grain as Day by default if none is provided
@jinghua-qa
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24341: fix: Viz migration adjustments - 1
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24341:
URL: https://github.com/apache/superset/pull/24341#issuecomment-1584598673
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24341](https://app.codecov.io/gh/apache/superset/pull/24341?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (254de28) into [master](https://app.codecov.io/gh/apache/superset/commit/bdb8bbef32cf9f782b6a7dc7a93c1ad737712536?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bdb8bbe) will **decrease** coverage by `11.12%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 254de28 differs from pull request most recent head 71c5610. Consider uploading reports for the commit 71c5610 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24341 +/- ##
===========================================
- Coverage 69.08% 57.96% -11.12%
===========================================
Files 1905 1905
Lines 74848 74851 +3
Branches 8108 8108
===========================================
- Hits 51705 43386 -8319
- Misses 21031 29353 +8322
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.67% <50.00%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.59% <50.00%> (+<0.01%)` | :arrow_up: |
| python | `60.43% <75.00%> (-22.84%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.08% <75.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/migrations/shared/migrate\_viz/base.py](https://app.codecov.io/gh/apache/superset/pull/24341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvbWlncmF0ZV92aXovYmFzZS5weQ==) | `84.31% <50.00%> (-0.69%)` | :arrow_down: |
| [...perset/migrations/shared/migrate\_viz/processors.py](https://app.codecov.io/gh/apache/superset/pull/24341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvbWlncmF0ZV92aXovcHJvY2Vzc29ycy5weQ==) | `76.59% <100.00%> (-23.41%)` | :arrow_down: |
... and [302 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24341/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #24341: fix: Viz migration adjustments - 1
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #24341:
URL: https://github.com/apache/superset/pull/24341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org