You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Gautam Worah (Jira)" <ji...@apache.org> on 2021/06/21 15:44:00 UTC
[jira] [Comment Edited] (LUCENE-9902) Update faceting API to use
modern Java features
[ https://issues.apache.org/jira/browse/LUCENE-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366671#comment-17366671 ]
Gautam Worah edited comment on LUCENE-9902 at 6/21/21, 3:43 PM:
----------------------------------------------------------------
Oh! I incorrectly put it under the Lucene 8.9 CHANGES section. It should've been under the Lucene 9.0 CHANGES section.
So yes, I think we need to adjust the file accordingly [~mayya]
Edit: Added a PR [here|https://github.com/apache/lucene/pull/190]
was (Author: gworah):
Oh! I incorrectly put it under the Lucene 8.9 CHANGES section. It should've been under the Lucene 9.0 CHANGES section.
So yes, I think we need to adjust the file accordingly [~mayya]
> Update faceting API to use modern Java features
> -----------------------------------------------
>
> Key: LUCENE-9902
> URL: https://issues.apache.org/jira/browse/LUCENE-9902
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Gautam Worah
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> I was using the {{public int getOrdinal(String dim, String[] path)}} API for a single {{path}} String and found myself creating an array with a single element. We can start using variable length args for this method.
> I also propose this change:
> I wanted to know the specific count of an ordinal using using the {{getValue}} API from {{IntTaxonomyFacets}} but the method is private. It would be good if we could change it to {{protected}} so that users can know the value of an ordinal without looking up the {{FacetLabel}} and then checking its value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org