You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yetus.apache.org by "张铎(Duo Zhang)" <pa...@gmail.com> on 2022/08/25 11:20:37 UTC
Fix NPE in DocletEnvironmentProcessor
Hi community, I've opened a PR to fix the NPE in DocletEnvironmentProcessor.
The fix is very easy, just adding a null check, but it is the last
important change to make HBase be able to build javadoc with JDK11.
Some CI checks are failed, it seems to be docker build issues. Not
sure how to fix them or retrigger them...
Thanks.
Re: Fix NPE in DocletEnvironmentProcessor
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
OK, good. Waiting for your good news~
Allen Wittenauer <aw...@apache.org> 于2022年9月28日周三 05:10写道：
>
> OK, I’ll start banging on it. WIll need to get in at least one patch to fix the Ruby CVEs.
>
> Currently leaning towards a 0.14.1 since I really don’t want to expend the effort to update everything else yet. (We’re overdue for an Ubuntu upgrade….)
>
>
>
>
> > On Sep 27, 2022, at 12:16 PM, Nick Dimiduk <nd...@apache.org> wrote:
> >
> > I looked briefly into the process for performing a yetus release. I saw
> > that there is documentation, but have not set about the “pre-flight” steps.
> > If someone else has time more immediate available, please don’t wait on me.
> >
> > Thanks,
> > Nick
> >
> > On Tue, Sep 27, 2022 at 16:37 张铎(Duo Zhang) <pa...@gmail.com> wrote:
> >
> >> Any updates here?
> >>
> >> Thanks.
> >>
> >> Allen Wittenauer <aw...@apache.org> 于2022年9月17日周六 12:53写道：
> >>>
> >>> I’m back in town so available to work on it unless you’d like to give it
> >> a shot Nick.
> >>>
> >>> Thanks!
> >>>
> >>>
> >>>> On Sep 16, 2022, at 9:12 AM, Nick Dimiduk <nd...@apache.org> wrote:
> >>>>
> >>>> I’ve never done a Yetus release but I’m happy to give it a try.
> >>>>
> >>>> On Fri, Sep 16, 2022 at 11:56 张铎(Duo Zhang) <pa...@gmail.com>
> >> wrote:
> >>>>
> >>>>> So is there a plan to make a new micro release?
> >>>>>
> >>>>> Thanks.
> >>>>>
> >>>>> Allen Wittenauer <aw...@effectivemachines.com.invalid> 于2022年8月30日周二
> >> 23:47写道：
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> On Aug 30, 2022, at 6:56 AM, Nick Dimiduk <nd...@apache.org>
> >> wrote:
> >>>>>>>
> >>>>>>> Do we have a need of a new minor release, or can we do a patch
> >> release?
> >>>>>>
> >>>>>> Off the top of my head, I don’t think there any major breaking
> >>>>> changes currently committed to main. I think it is all bugfixes. I
> >> think
> >>>>> the only ‘breaking’ change is the upgrade to Rat. So micro release
> >> should
> >>>>> be fine.
> >>>>>
> >>>
> >>
>
Re: Fix NPE in DocletEnvironmentProcessor
Posted by Allen Wittenauer <aw...@apache.org>.
OK, I’ll start banging on it. WIll need to get in at least one patch to fix the Ruby CVEs.
Currently leaning towards a 0.14.1 since I really don’t want to expend the effort to update everything else yet. (We’re overdue for an Ubuntu upgrade….)
> On Sep 27, 2022, at 12:16 PM, Nick Dimiduk <nd...@apache.org> wrote:
>
> I looked briefly into the process for performing a yetus release. I saw
> that there is documentation, but have not set about the “pre-flight” steps.
> If someone else has time more immediate available, please don’t wait on me.
>
> Thanks,
> Nick
>
> On Tue, Sep 27, 2022 at 16:37 张铎(Duo Zhang) <pa...@gmail.com> wrote:
>
>> Any updates here?
>>
>> Thanks.
>>
>> Allen Wittenauer <aw...@apache.org> 于2022年9月17日周六 12:53写道：
>>>
>>> I’m back in town so available to work on it unless you’d like to give it
>> a shot Nick.
>>>
>>> Thanks!
>>>
>>>
>>>> On Sep 16, 2022, at 9:12 AM, Nick Dimiduk <nd...@apache.org> wrote:
>>>>
>>>> I’ve never done a Yetus release but I’m happy to give it a try.
>>>>
>>>> On Fri, Sep 16, 2022 at 11:56 张铎(Duo Zhang) <pa...@gmail.com>
>> wrote:
>>>>
>>>>> So is there a plan to make a new micro release?
>>>>>
>>>>> Thanks.
>>>>>
>>>>> Allen Wittenauer <aw...@effectivemachines.com.invalid> 于2022年8月30日周二
>> 23:47写道：
>>>>>>
>>>>>>
>>>>>>
>>>>>>> On Aug 30, 2022, at 6:56 AM, Nick Dimiduk <nd...@apache.org>
>> wrote:
>>>>>>>
>>>>>>> Do we have a need of a new minor release, or can we do a patch
>> release?
>>>>>>
>>>>>> Off the top of my head, I don’t think there any major breaking
>>>>> changes currently committed to main. I think it is all bugfixes. I
>> think
>>>>> the only ‘breaking’ change is the upgrade to Rat. So micro release
>> should
>>>>> be fine.
>>>>>
>>>
>>
Re: Fix NPE in DocletEnvironmentProcessor
Posted by Nick Dimiduk <nd...@apache.org>.
I looked briefly into the process for performing a yetus release. I saw
that there is documentation, but have not set about the “pre-flight” steps.
If someone else has time more immediate available, please don’t wait on me.
Thanks,
Nick
On Tue, Sep 27, 2022 at 16:37 张铎(Duo Zhang) <pa...@gmail.com> wrote:
> Any updates here?
>
> Thanks.
>
> Allen Wittenauer <aw...@apache.org> 于2022年9月17日周六 12:53写道：
> >
> > I’m back in town so available to work on it unless you’d like to give it
> a shot Nick.
> >
> > Thanks!
> >
> >
> > > On Sep 16, 2022, at 9:12 AM, Nick Dimiduk <nd...@apache.org> wrote:
> > >
> > > I’ve never done a Yetus release but I’m happy to give it a try.
> > >
> > > On Fri, Sep 16, 2022 at 11:56 张铎(Duo Zhang) <pa...@gmail.com>
> wrote:
> > >
> > >> So is there a plan to make a new micro release?
> > >>
> > >> Thanks.
> > >>
> > >> Allen Wittenauer <aw...@effectivemachines.com.invalid> 于2022年8月30日周二
> 23:47写道：
> > >>>
> > >>>
> > >>>
> > >>>> On Aug 30, 2022, at 6:56 AM, Nick Dimiduk <nd...@apache.org>
> wrote:
> > >>>>
> > >>>> Do we have a need of a new minor release, or can we do a patch
> release?
> > >>>
> > >>> Off the top of my head, I don’t think there any major breaking
> > >> changes currently committed to main. I think it is all bugfixes. I
> think
> > >> the only ‘breaking’ change is the upgrade to Rat. So micro release
> should
> > >> be fine.
> > >>
> >
>
Re: Fix NPE in DocletEnvironmentProcessor
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
Any updates here?
Thanks.
Allen Wittenauer <aw...@apache.org> 于2022年9月17日周六 12:53写道：
>
> I’m back in town so available to work on it unless you’d like to give it a shot Nick.
>
> Thanks!
>
>
> > On Sep 16, 2022, at 9:12 AM, Nick Dimiduk <nd...@apache.org> wrote:
> >
> > I’ve never done a Yetus release but I’m happy to give it a try.
> >
> > On Fri, Sep 16, 2022 at 11:56 张铎(Duo Zhang) <pa...@gmail.com> wrote:
> >
> >> So is there a plan to make a new micro release?
> >>
> >> Thanks.
> >>
> >> Allen Wittenauer <aw...@effectivemachines.com.invalid> 于2022年8月30日周二 23:47写道：
> >>>
> >>>
> >>>
> >>>> On Aug 30, 2022, at 6:56 AM, Nick Dimiduk <nd...@apache.org> wrote:
> >>>>
> >>>> Do we have a need of a new minor release, or can we do a patch release?
> >>>
> >>> Off the top of my head, I don’t think there any major breaking
> >> changes currently committed to main. I think it is all bugfixes. I think
> >> the only ‘breaking’ change is the upgrade to Rat. So micro release should
> >> be fine.
> >>
>
Re: Fix NPE in DocletEnvironmentProcessor
Posted by Allen Wittenauer <aw...@apache.org>.
I’m back in town so available to work on it unless you’d like to give it a shot Nick.
Thanks!
> On Sep 16, 2022, at 9:12 AM, Nick Dimiduk <nd...@apache.org> wrote:
>
> I’ve never done a Yetus release but I’m happy to give it a try.
>
> On Fri, Sep 16, 2022 at 11:56 张铎(Duo Zhang) <pa...@gmail.com> wrote:
>
>> So is there a plan to make a new micro release?
>>
>> Thanks.
>>
>> Allen Wittenauer <aw...@effectivemachines.com.invalid> 于2022年8月30日周二 23:47写道：
>>>
>>>
>>>
>>>> On Aug 30, 2022, at 6:56 AM, Nick Dimiduk <nd...@apache.org> wrote:
>>>>
>>>> Do we have a need of a new minor release, or can we do a patch release?
>>>
>>> Off the top of my head, I don’t think there any major breaking
>> changes currently committed to main. I think it is all bugfixes. I think
>> the only ‘breaking’ change is the upgrade to Rat. So micro release should
>> be fine.
>>
Re: Fix NPE in DocletEnvironmentProcessor
Posted by Nick Dimiduk <nd...@apache.org>.
I’ve never done a Yetus release but I’m happy to give it a try.
On Fri, Sep 16, 2022 at 11:56 张铎(Duo Zhang) <pa...@gmail.com> wrote:
> So is there a plan to make a new micro release?
>
> Thanks.
>
> Allen Wittenauer <aw...@effectivemachines.com.invalid> 于2022年8月30日周二 23:47写道：
> >
> >
> >
> > > On Aug 30, 2022, at 6:56 AM, Nick Dimiduk <nd...@apache.org> wrote:
> > >
> > > Do we have a need of a new minor release, or can we do a patch release?
> >
> > Off the top of my head, I don’t think there any major breaking
> changes currently committed to main. I think it is all bugfixes. I think
> the only ‘breaking’ change is the upgrade to Rat. So micro release should
> be fine.
>
Re: Fix NPE in DocletEnvironmentProcessor
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
So is there a plan to make a new micro release?
Thanks.
Allen Wittenauer <aw...@effectivemachines.com.invalid> 于2022年8月30日周二 23:47写道：
>
>
>
> > On Aug 30, 2022, at 6:56 AM, Nick Dimiduk <nd...@apache.org> wrote:
> >
> > Do we have a need of a new minor release, or can we do a patch release?
>
> Off the top of my head, I don’t think there any major breaking changes currently committed to main. I think it is all bugfixes. I think the only ‘breaking’ change is the upgrade to Rat. So micro release should be fine.
Re: Fix NPE in DocletEnvironmentProcessor
Posted by Allen Wittenauer <aw...@effectivemachines.com.INVALID>.
> On Aug 30, 2022, at 6:56 AM, Nick Dimiduk <nd...@apache.org> wrote:
>
> Do we have a need of a new minor release, or can we do a patch release?
Off the top of my head, I don’t think there any major breaking changes currently committed to main. I think it is all bugfixes. I think the only ‘breaking’ change is the upgrade to Rat. So micro release should be fine.
Re: Fix NPE in DocletEnvironmentProcessor
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
For HBase, a patch release is enough. I'm not sure about yetus...
Nick Dimiduk <nd...@apache.org> 于2022年8月30日周二 21:56写道：
>
> Do we have a need of a new minor release, or can we do a patch release?
>
> On Tue, Aug 30, 2022 at 11:42 AM 张铎(Duo Zhang) <pa...@gmail.com>
> wrote:
>
> > Thanks!
> >
> > Looking forward to the 0.15.0 release :)
> >
> > Allen Wittenauer <aw...@effectivemachines.com.invalid> 于2022年8月30日周二 00:16写道：
> > >
> > >
> > > Thanks for the contribution!
> > >
> > > For those playing at home, this PR was merged in a bit ago and all of
> > the CI checks for main are now running with this change in place. We had
> > to get YETUS-1194 in place in order to CI working again.
> > >
> > >
> > > > On Aug 25, 2022, at 4:21 AM, 张铎(Duo Zhang) <pa...@gmail.com>
> > wrote:
> > > >
> > > > Oh, seems I sent to a wrong email address...
> > > >
> > > > ---------- Forwarded message ---------
> > > > 发件人： 张铎(Duo Zhang) <pa...@gmail.com>
> > > > Date: 2022年8月25日周四 19:20
> > > > Subject: Fix NPE in DocletEnvironmentProcessor
> > > > To: <ye...@apache.org>
> > > >
> > > >
> > > > Hi community, I've opened a PR to fix the NPE in
> > DocletEnvironmentProcessor.
> > > >
> > > > The fix is very easy, just adding a null check, but it is the last
> > > > important change to make HBase be able to build javadoc with JDK11.
> > > >
> > > > Some CI checks are failed, it seems to be docker build issues. Not
> > > > sure how to fix them or retrigger them...
> > > >
> > > > Thanks.
> > >
> >
Re: Fix NPE in DocletEnvironmentProcessor
Posted by Nick Dimiduk <nd...@apache.org>.
Do we have a need of a new minor release, or can we do a patch release?
On Tue, Aug 30, 2022 at 11:42 AM 张铎(Duo Zhang) <pa...@gmail.com>
wrote:
> Thanks!
>
> Looking forward to the 0.15.0 release :)
>
> Allen Wittenauer <aw...@effectivemachines.com.invalid> 于2022年8月30日周二 00:16写道：
> >
> >
> > Thanks for the contribution!
> >
> > For those playing at home, this PR was merged in a bit ago and all of
> the CI checks for main are now running with this change in place. We had
> to get YETUS-1194 in place in order to CI working again.
> >
> >
> > > On Aug 25, 2022, at 4:21 AM, 张铎(Duo Zhang) <pa...@gmail.com>
> wrote:
> > >
> > > Oh, seems I sent to a wrong email address...
> > >
> > > ---------- Forwarded message ---------
> > > 发件人： 张铎(Duo Zhang) <pa...@gmail.com>
> > > Date: 2022年8月25日周四 19:20
> > > Subject: Fix NPE in DocletEnvironmentProcessor
> > > To: <ye...@apache.org>
> > >
> > >
> > > Hi community, I've opened a PR to fix the NPE in
> DocletEnvironmentProcessor.
> > >
> > > The fix is very easy, just adding a null check, but it is the last
> > > important change to make HBase be able to build javadoc with JDK11.
> > >
> > > Some CI checks are failed, it seems to be docker build issues. Not
> > > sure how to fix them or retrigger them...
> > >
> > > Thanks.
> >
>
Re: Fix NPE in DocletEnvironmentProcessor
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
Thanks!
Looking forward to the 0.15.0 release :)
Allen Wittenauer <aw...@effectivemachines.com.invalid> 于2022年8月30日周二 00:16写道：
>
>
> Thanks for the contribution!
>
> For those playing at home, this PR was merged in a bit ago and all of the CI checks for main are now running with this change in place. We had to get YETUS-1194 in place in order to CI working again.
>
>
> > On Aug 25, 2022, at 4:21 AM, 张铎(Duo Zhang) <pa...@gmail.com> wrote:
> >
> > Oh, seems I sent to a wrong email address...
> >
> > ---------- Forwarded message ---------
> > 发件人： 张铎(Duo Zhang) <pa...@gmail.com>
> > Date: 2022年8月25日周四 19:20
> > Subject: Fix NPE in DocletEnvironmentProcessor
> > To: <ye...@apache.org>
> >
> >
> > Hi community, I've opened a PR to fix the NPE in DocletEnvironmentProcessor.
> >
> > The fix is very easy, just adding a null check, but it is the last
> > important change to make HBase be able to build javadoc with JDK11.
> >
> > Some CI checks are failed, it seems to be docker build issues. Not
> > sure how to fix them or retrigger them...
> >
> > Thanks.
>
Re: Fix NPE in DocletEnvironmentProcessor
Posted by Allen Wittenauer <aw...@effectivemachines.com.INVALID>.
Thanks for the contribution!
For those playing at home, this PR was merged in a bit ago and all of the CI checks for main are now running with this change in place. We had to get YETUS-1194 in place in order to CI working again.
> On Aug 25, 2022, at 4:21 AM, 张铎(Duo Zhang) <pa...@gmail.com> wrote:
>
> Oh, seems I sent to a wrong email address...
>
> ---------- Forwarded message ---------
> 发件人： 张铎(Duo Zhang) <pa...@gmail.com>
> Date: 2022年8月25日周四 19:20
> Subject: Fix NPE in DocletEnvironmentProcessor
> To: <ye...@apache.org>
>
>
> Hi community, I've opened a PR to fix the NPE in DocletEnvironmentProcessor.
>
> The fix is very easy, just adding a null check, but it is the last
> important change to make HBase be able to build javadoc with JDK11.
>
> Some CI checks are failed, it seems to be docker build issues. Not
> sure how to fix them or retrigger them...
>
> Thanks.
Fwd: Fix NPE in DocletEnvironmentProcessor
Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.
Oh, seems I sent to a wrong email address...
---------- Forwarded message ---------
发件人： 张铎(Duo Zhang) <pa...@gmail.com>
Date: 2022年8月25日周四 19:20
Subject: Fix NPE in DocletEnvironmentProcessor
To: <ye...@apache.org>
Hi community, I've opened a PR to fix the NPE in DocletEnvironmentProcessor.
The fix is very easy, just adding a null check, but it is the last
important change to make HBase be able to build javadoc with JDK11.
Some CI checks are failed, it seems to be docker build issues. Not
sure how to fix them or retrigger them...
Thanks.