You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/08/06 06:39:12 UTC

[GitHub] [ignite-python-thin-client] ivandasch commented on pull request #48: IGNITE-15266 Add isclass check to is_hinted

ivandasch commented on pull request #48:
URL: https://github.com/apache/ignite-python-thin-client/pull/48#issuecomment-894038792


   @bojidar-bg Great catch, Bojidar. Could you please add a test case for it? I've really appreciate your effort and create some tests for your case, please add tests to your patch. Also, we have already imported `inspect` here, please use `inspect.isclass`.
   Or you can just use my patch. Apply it and commit to your branch. After it, I will merge you PR. Thank you!
   
   Also I'd suggest not to use OBJECT_ARRAY at all, Ignite itself doesn't have a great support of it. Use Collections (simple list) instead.
   [Add_tests_to_patch.txt](https://github.com/apache/ignite-python-thin-client/files/6943533/Add_tests_to_patch.txt)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org