You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/05/16 21:23:41 UTC
Review Request 21565: Added JSON support to flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-1344
https://issues.apache.org/jira/browse/MESOS-1344
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21565: Added JSON support to flags.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43248
-----------------------------------------------------------
Ship it!
Will be useful for rate limiting configuration :)
- Jiang Yan Xu
On May 16, 2014, 12:23 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 12:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43673
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp
<https://reviews.apache.org/r/21565/#comment77962>
What's hard about relative file paths? A brief comment explaining why they aren't handled would be great!
- Benjamin Hindman
On May 20, 2014, 6:48 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 6:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/
-----------------------------------------------------------
(Updated May 22, 2014, 12:37 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased. NNFR.
Bugs: MESOS-1344
https://issues.apache.org/jira/browse/MESOS-1344
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21565: Added JSON support to flags.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/
-----------------------------------------------------------
(Updated May 20, 2014, 6:48 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased. PTAL.
Bugs: MESOS-1344
https://issues.apache.org/jira/browse/MESOS-1344
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21565: Added JSON support to flags.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/
-----------------------------------------------------------
(Updated May 19, 2014, 9:28 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benh's comments. also re-added "depends on".
Bugs: MESOS-1344
https://issues.apache.org/jira/browse/MESOS-1344
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21565: Added JSON support to flags.
Posted by Vinod Kone <vi...@gmail.com>.
> On May 19, 2014, 7:34 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 18
> > <https://reviews.apache.org/r/21565/diff/3/?file=583936#file583936line18>
> >
> > New file that you're missing from this diff?
that was done in a dependent review. but one of the review updates removed the "depends on" field :/. will reset it.
> On May 19, 2014, 7:34 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 65
> > <https://reviews.apache.org/r/21565/diff/3/?file=583936#file583936line65>
> >
> > Maybe grab std::map along with std::string while you're at it?
done.
> On May 19, 2014, 7:34 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 555
> > <https://reviews.apache.org/r/21565/diff/3/?file=583936#file583936line555>
> >
> > I'm guessing TemporaryDirectoryTest defined in the missing utils.hpp?
see my first reply.
> On May 19, 2014, 7:34 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 580
> > <https://reviews.apache.org/r/21565/diff/3/?file=583936#file583936line580>
> >
> > What's 'tmpdir'? Perhaps it's exposed in the mysterious TemporaryDirectoryTest? We didn't expose 'tmpdir' in Mesos but instead used os::getcwd() for stuff like this.
see above.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43402
-----------------------------------------------------------
On May 19, 2014, 9:28 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 9:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43402
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
<https://reviews.apache.org/r/21565/#comment77499>
New file that you're missing from this diff?
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
<https://reviews.apache.org/r/21565/#comment77498>
Maybe grab std::map along with std::string while you're at it?
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
<https://reviews.apache.org/r/21565/#comment77497>
Not yours, but add a space after foreachpair please.
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
<https://reviews.apache.org/r/21565/#comment77492>
How about ASSERT_SOME(flags.load(values))?
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
<https://reviews.apache.org/r/21565/#comment77491>
Maybe ASSERT_SOME_EQ since how do you know 'json.get()' will not fail?
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
<https://reviews.apache.org/r/21565/#comment77496>
I'm guessing TemporaryDirectoryTest defined in the missing utils.hpp?
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
<https://reviews.apache.org/r/21565/#comment77495>
What's 'tmpdir'? Perhaps it's exposed in the mysterious TemporaryDirectoryTest? We didn't expose 'tmpdir' in Mesos but instead used os::getcwd() for stuff like this.
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
<https://reviews.apache.org/r/21565/#comment77493>
ASSERT_SOME's here like above too.
- Benjamin Hindman
On May 17, 2014, 1:13 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 17, 2014, 1:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On May 18, 2014, 5:01 p.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp, lines 81-82
> > <https://reviews.apache.org/r/21565/diff/3/?file=583935#file583935line81>
> >
> > What if it's a relative path? Who should call os::realpath()?
>
> Vinod Kone wrote:
> Yea. Thats a bit tricky. For now we only support absolute paths.
>
> Jiang Yan Xu wrote:
> Yeah, then in main.cpp we need to check that. But surely in another review where these flags are used.
How come a relative path is difficult? It would be great to leave a comment here for posterity so when someone does add relative paths support they consider the tricky case you're envisioning.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43326
-----------------------------------------------------------
On May 17, 2014, 1:13 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 17, 2014, 1:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On May 18, 2014, 10:01 a.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp, lines 81-82
> > <https://reviews.apache.org/r/21565/diff/3/?file=583935#file583935line81>
> >
> > What if it's a relative path? Who should call os::realpath()?
>
> Vinod Kone wrote:
> Yea. Thats a bit tricky. For now we only support absolute paths.
Yeah, then in main.cpp we need to check that. But surely in another review where these flags are used.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43326
-----------------------------------------------------------
On May 16, 2014, 6:13 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 6:13 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On May 18, 2014, 5:01 p.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp, lines 81-82
> > <https://reviews.apache.org/r/21565/diff/3/?file=583935#file583935line81>
> >
> > What if it's a relative path? Who should call os::realpath()?
>
> Vinod Kone wrote:
> Yea. Thats a bit tricky. For now we only support absolute paths.
>
> Jiang Yan Xu wrote:
> Yeah, then in main.cpp we need to check that. But surely in another review where these flags are used.
>
> Benjamin Hindman wrote:
> How come a relative path is difficult? It would be great to leave a comment here for posterity so when someone does add relative paths support they consider the tricky case you're envisioning.
>
> Vinod Kone wrote:
> The tricky part is to figure out that the flag value is a relative path. When the value is "foo" it's not easy, AFAICT, to say whether it is a JSON string or a file path. We could say that if the value starts with "{" it's a JSON string but I think that's not enough because " {" and " \n {" are also valid prefixes for a JSON string? Does that make sense?
Makes sense, let's just capture this as a comment so others that come around have this as a starting point for thinking about this.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43326
-----------------------------------------------------------
On May 20, 2014, 6:48 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 6:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Vinod Kone <vi...@gmail.com>.
> On May 18, 2014, 5:01 p.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp, lines 81-82
> > <https://reviews.apache.org/r/21565/diff/3/?file=583935#file583935line81>
> >
> > What if it's a relative path? Who should call os::realpath()?
>
> Vinod Kone wrote:
> Yea. Thats a bit tricky. For now we only support absolute paths.
>
> Jiang Yan Xu wrote:
> Yeah, then in main.cpp we need to check that. But surely in another review where these flags are used.
>
> Benjamin Hindman wrote:
> How come a relative path is difficult? It would be great to leave a comment here for posterity so when someone does add relative paths support they consider the tricky case you're envisioning.
The tricky part is to figure out that the flag value is a relative path. When the value is "foo" it's not easy, AFAICT, to say whether it is a JSON string or a file path. We could say that if the value starts with "{" it's a JSON string but I think that's not enough because " {" and " \n {" are also valid prefixes for a JSON string? Does that make sense?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43326
-----------------------------------------------------------
On May 17, 2014, 1:13 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 17, 2014, 1:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Vinod Kone <vi...@gmail.com>.
> On May 18, 2014, 5:01 p.m., Jiang Yan Xu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp, lines 81-82
> > <https://reviews.apache.org/r/21565/diff/3/?file=583935#file583935line81>
> >
> > What if it's a relative path? Who should call os::realpath()?
Yea. Thats a bit tricky. For now we only support absolute paths.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43326
-----------------------------------------------------------
On May 17, 2014, 1:13 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 17, 2014, 1:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43326
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp
<https://reviews.apache.org/r/21565/#comment77426>
What if it's a relative path? Who should call os::realpath()?
- Jiang Yan Xu
On May 16, 2014, 6:13 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 6:13 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/#review43312
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On May 16, 2014, 6:13 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21565/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 6:13 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1344
> https://issues.apache.org/jira/browse/MESOS-1344
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
>
> Diff: https://reviews.apache.org/r/21565/diff/
>
>
> Testing
> -------
>
> stout make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21565: Added JSON support to flags.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/
-----------------------------------------------------------
(Updated May 17, 2014, 1:13 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased.
Bugs: MESOS-1344
https://issues.apache.org/jira/browse/MESOS-1344
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone
Re: Review Request 21565: Added JSON support to flags.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21565/
-----------------------------------------------------------
(Updated May 16, 2014, 11:03 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
added support for parsing json from a file. PTAL.
Bugs: MESOS-1344
https://issues.apache.org/jira/browse/MESOS-1344
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp a781f14aec9dc5b6350d8e5452a7131cbb891595
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ae6d9c1dc0e5f774f668acf62c7dbfbe46529b48
Diff: https://reviews.apache.org/r/21565/diff/
Testing
-------
stout make check
Thanks,
Vinod Kone