[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10247: Add PinotHelixResourceManager to MetadataEventNotifier

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10247:
URL: https://github.com/apache/pinot/pull/10247#discussion_r1100614780


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/events/MetadataEventNotifierFactory.java:
##########
@@ -27,16 +28,19 @@ public abstract class MetadataEventNotifierFactory {
   public static final Logger LOGGER = LoggerFactory.getLogger(MetadataEventNotifierFactory.class);
   public static final String METADATA_EVENT_CLASS_CONFIG = "factory.class";
 
+  protected static PinotHelixResourceManager _pinotHelixResourceManager;
+
   public abstract void init(PinotConfiguration configuration);

Review Comment:
   If you need `PinotHelixResourceManager` in the `MetadataEventNotifierFactory`, shouldn't you add it into the `init()`? Putting it as static variable is quite hacky



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org